-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ready for review #1
Conversation
I am creating a pull request to merge into the main repository. Thanks for your review! @mk3890 @rhodesconover8 @matthew-l-weber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@chuckwolber @mk3890 I'll take on most of these changes when I'm back. I wanted to have @LuminaScript publish a draft before she's done this next week! |
Thank you! |
@chuckwolber The latest commit should have addressed all the concerns you pointed out in the comments. Thank you for reviewing my code! Please let me know if any further changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing your tool I found a few things that you may need to fix.
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]> Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]> Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]> Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]> Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]> Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]> Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]> Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]> Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]> Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
I found a dependency bug; tooling needs to run inside a container. (will make a ticket)
|
Moved a rebased set of changes with some fixups to PR2 - https://github.com/elisa-tech/delta-kernel/pull/3/files |
Thank you @LuminaScript for the great summer! |
Review of the delta-kernel Tool
This pull request introduces the delta-kernel tool, which generates compile-time version update analyses between two Linux kernel versions.