Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #4 Chat UI #6

Merged
merged 4 commits into from
Mar 30, 2024
Merged

feat: #4 Chat UI #6

merged 4 commits into from
Mar 30, 2024

Conversation

jo-elimu
Copy link
Member

@jo-elimu jo-elimu commented Mar 30, 2024

close #4

Summary by CodeRabbit

  • New Features
    • Introduced automated build process for different operating systems and Java versions using GitHub Actions.
    • Added chat functionality with a generative AI model, including UI components for chat interactions.
    • Implemented a menu screen with scrollable list of items and interaction capabilities.
  • Enhancements
    • Updated app build configurations, including plugins, namespace, and dependencies for improved performance and compatibility.
    • Enhanced UI theme with new color schemes and typography settings for dark mode support.
  • Documentation
    • Added build instructions for setting up apiKey in the build process.
  • Refactor
    • Updated package names and removed unnecessary comments and settings for cleaner codebase.
  • Chores
    • Updated Gradle wrapper and scripts for better compatibility and performance.

@jo-elimu jo-elimu requested a review from saharulik March 30, 2024 08:22
@jo-elimu jo-elimu self-assigned this Mar 30, 2024
Copy link

coderabbitai bot commented Mar 30, 2024

Warning

Rate Limit Exceeded

@jo-elimu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 22 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 3bafc58 and 2b8201c.

Walkthrough

This update introduces a comprehensive overhaul of an Android application, focusing on integrating a chat UI with generative AI capabilities. It modernizes the build setup, migrates namespaces, and lowers the minimum SDK requirement to widen device compatibility. The app now features a Compose-based UI for seamless navigation and interaction within chat functionalities, supported by a robust backend model for generative conversations. Additionally, it enhances the developer experience with updated build scripts and dependency management.

Changes

File Path Change Summary
.github/workflows/gradle.yml Introduced "Gradle CI" workflow for automated builds across various OS and Java versions.
README.md Added instructions for configuring apiKey.
app/build.gradle.kts Plugin, namespace, SDK, and dependency updates.
app/src/main/kotlin/.../GenerativeAiViewModelFactory.kt
.../MainActivity.kt
.../MenuScreen.kt
.../feature/chat/ChatMessage.kt
.../feature/chat/ChatScreen.kt
.../feature/chat/ChatUiState.kt
.../feature/chat/ChatViewModel.kt
.../ui/theme/Color.kt
.../ui/theme/Theme.kt
.../ui/theme/Type.kt
.../util/UriSaver.kt
Added and updated Kotlin files for chat UI functionality, theming, and utilities.
build.gradle.kts Added buildscript dependencies for updated plugins.
gradle.properties Updated JVM arguments, Android build features, and removed outdated settings.
gradle/wrapper/gradle-wrapper.properties Removed a timestamp comment.
gradlew, gradlew.bat Updated scripts for enhanced shell compatibility, error handling, and argument processing.
settings.gradle.kts Modified plugin management and repository configurations.

Possibly related issues

  • Issue Build Android app with chat UI #4: The changes in this PR introduce a chat UI and underlying functionality which directly addresses the objective of developing an Android application with a chat user interface, potentially fulfilling the requirements outlined in the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Comment on lines +153 to +203
@Composable
fun MessageInput(
onSendMessage: (String) -> Unit,
resetScroll: () -> Unit = {}
) {
var userMessage by rememberSaveable { mutableStateOf("") }

ElevatedCard(
modifier = Modifier
.fillMaxWidth()
) {
Row(
modifier = Modifier
.padding(16.dp)
.fillMaxWidth()
) {
OutlinedTextField(
value = userMessage,
label = { Text(stringResource(R.string.chat_label)) },
onValueChange = { userMessage = it },
keyboardOptions = KeyboardOptions(
capitalization = KeyboardCapitalization.Sentences,
),
modifier = Modifier
.align(Alignment.CenterVertically)
.fillMaxWidth()
.weight(0.85f)
)
IconButton(
onClick = {
if (userMessage.isNotBlank()) {
onSendMessage(userMessage)
userMessage = ""
resetScroll()
}
},
modifier = Modifier
.padding(start = 16.dp)
.align(Alignment.CenterVertically)
.fillMaxWidth()
.weight(0.15f)
) {
Icon(
Icons.Default.Send,
contentDescription = stringResource(R.string.action_send),
modifier = Modifier
)
}
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MessageInput composable function provides a user-friendly interface for message input. However, consider adding an accessibility label to the send button for screen readers, improving the app's accessibility.

+ contentDescription = stringResource(R.string.action_send),

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
@Composable
fun MessageInput(
onSendMessage: (String) -> Unit,
resetScroll: () -> Unit = {}
) {
var userMessage by rememberSaveable { mutableStateOf("") }
ElevatedCard(
modifier = Modifier
.fillMaxWidth()
) {
Row(
modifier = Modifier
.padding(16.dp)
.fillMaxWidth()
) {
OutlinedTextField(
value = userMessage,
label = { Text(stringResource(R.string.chat_label)) },
onValueChange = { userMessage = it },
keyboardOptions = KeyboardOptions(
capitalization = KeyboardCapitalization.Sentences,
),
modifier = Modifier
.align(Alignment.CenterVertically)
.fillMaxWidth()
.weight(0.85f)
)
IconButton(
onClick = {
if (userMessage.isNotBlank()) {
onSendMessage(userMessage)
userMessage = ""
resetScroll()
}
},
modifier = Modifier
.padding(start = 16.dp)
.align(Alignment.CenterVertically)
.fillMaxWidth()
.weight(0.15f)
) {
Icon(
Icons.Default.Send,
contentDescription = stringResource(R.string.action_send),
modifier = Modifier
)
}
}
}
}
@Composable
fun MessageInput(
onSendMessage: (String) -> Unit,
resetScroll: () -> Unit = {}
) {
var userMessage by rememberSaveable { mutableStateOf("") }
ElevatedCard(
modifier = Modifier
.fillMaxWidth()
) {
Row(
modifier = Modifier
.padding(16.dp)
.fillMaxWidth()
) {
OutlinedTextField(
value = userMessage,
label = { Text(stringResource(R.string.chat_label)) },
onValueChange = { userMessage = it },
keyboardOptions = KeyboardOptions(
capitalization = KeyboardCapitalization.Sentences,
),
modifier = Modifier
.align(Alignment.CenterVertically)
.fillMaxWidth()
.weight(0.85f)
)
IconButton(
onClick = {
if (userMessage.isNotBlank()) {
onSendMessage(userMessage)
userMessage = ""
resetScroll()
}
},
modifier = Modifier
.padding(start = 16.dp)
.align(Alignment.CenterVertically)
.fillMaxWidth()
.weight(0.15f)
) {
Icon(
Icons.Default.Send,
contentDescription = stringResource(R.string.action_send),
modifier = Modifier
)
}
}
}
}

@jo-elimu jo-elimu merged commit 7c50884 into main Mar 30, 2024
0 of 3 checks passed
@jo-elimu jo-elimu deleted the 4-chat-ui branch March 30, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Android app with chat UI
1 participant