Skip to content

Drop python<3.9, support modern libraries #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Mar 23, 2025
Merged

Drop python<3.9, support modern libraries #48

merged 37 commits into from
Mar 23, 2025

Conversation

lopuhin
Copy link
Contributor

@lopuhin lopuhin commented Mar 20, 2025

In this PR we drop support for python 3.8 and older, as they are past their end of life. We add support to scikit-learn 1.x (testing on 1.6), and drop support for scikit-learn < 1.0

There are a few missing features left for future PRs:

  • In this PR I'm disabling tests of gradcam explanation with Keras, as we required TF 1.x, but it does not support python 3.9+ so it's not breaking backwards compatibility as this did not work anyways. See updates Keras and tensorflow version [MNT] #47
  • XGBoost starting from 2.0 fails some tests, but XGBoost 1.x works, so we document this and leave support for newer XGBoost for future PRs (and issue a warning if we detect an old XGBoost) -- this is also backwards compatible, see Support XGBoost 2.x and 3.x #49
  • docs build has a lot of warnings, ideally we fix them and treat as errors, like before -- this is a blocker for next release

@lopuhin lopuhin changed the title [WIP] Drop python before 3.9, sklearn before 1.0, support modern libraries [WIP] Drop python<3.9, support modern libraries Mar 20, 2025
@lopuhin lopuhin changed the title [WIP] Drop python<3.9, support modern libraries Drop python<3.9, support modern libraries Mar 23, 2025
@lopuhin
Copy link
Contributor Author

lopuhin commented Mar 23, 2025

Updated description with the current state, this looks good to merge as the build is green and remaining issues were present previously.

@lopuhin lopuhin merged commit a86d2cf into master Mar 23, 2025
9 checks passed
@lopuhin lopuhin deleted the py39 branch March 23, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant