Use platform preprocessor checks #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using CMake to check the platform and then set a target compile definition to indicate the platform, just directly check the platform just directly check the platform by checking known platform defines.
RytoEX
force-pushed
the
use-platform-preprocessor
branch
from
274520c to
d61815a
Compare
RytoEX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using CMake to check the platform and then set a target compile definition to indicate the platform, just directly check the platform by checking known platform defines.
This removes the need for consumers who do not use this repo's CMakeLists.txt to set
_UP_WINDOWSor_UP_MAC.If this was done for a particular reason, feel free to close this pull request.
I don't know how
EVH_AVOID_UNNEEDED_COPY_CONSTRUCTORSis used because it isn't used anywhere in this repo, so you'll have to check that that change works for you.