-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook to infer reaction constants of a stochastic enzyme reaction #9
base: master
Are you sure you want to change the base?
Conversation
Random_state argument is used in definition of simulator, but it is no actually used, therefore result will vary between runs. running notebook is incredible slow because batch_size=1. I didn't even had patience to wait it complete ;) I don't blame anyone but Elfi for this, as using batch_size over one is too hard at the moment. Different autocovariance functions could be defined in single function:
and then give correct value for i, for example: |
I think this notebook is prepared really well. Below are my comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent and very well documented notebook!
Some comments for consideration:
- In
gillespie
, there's unnecessary mix of +-1 withindex
- Isn't the convention usually that rates (and their priors) are in [0,1] and the stoichiometry matrices handle splitting/merging of molecules?
c3
could be a hierarchical prior that depends onc2
(since c2+c3 <= 1)- For some reason the labelling in figure resulting from
In [6]
does not match the code??? - Same figure^, maybe comment why the reactions happen very fast during the first ms
- You could use 1 autocov function for all 4 species
- "Note: number of samples = N/quantile." Perhaps better to use the word "proposals" to avoid confusion between samples from prior vs. posterior
- Priors were set in range [0,2], so why plots from
In [21]
have range [0,3]? - What was the choice of summary statistics based on? The output from simulator is not particularly noisy, so calculating distance direct from output might work as well.
- Awesome, I appreciate the use of the Triton cluster, but the notebook should preferably be self-contained; it's fine to mention results obtained elsewhere, but loading non-existent files is maybe not
- Move to zoo/notebooks/enzyme_reaction.ipynb or something
@OssiGalkin It's hardly the fault of ELFI if the code is slow with See code in elfi.examples.lotka_volterra for a somewhat similar case in vectorized form. |
Thank you everyone for the comments! I will make the updates soon. |
Summary:
Notebook demonstrating the use of ELFI to perform ABC inference of reactions constants of a toy stochastic enzyme reaction.
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: