[26860] GS1 Standard ZurRose #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huthomas
requested changes
Feb 10, 2025
| } | ||
| URL xsdUrl = bundle.getEntry(Constants.XSD_RELATIVE_PATH); | ||
| if (xsdUrl == null) { | ||
| throw new XChangeException("XSD file not found: " + Constants.XSD_RELATIVE_PATH); |
There was a problem hiding this comment.
Weshalb ist das hier eine XChangeException ? Ich sehe keine Verbindung zum xchange code, daher würde ich eine IllegalStateException vorschlagen.
huthomas
requested changes
Feb 12, 2025
Comment on lines
38
to
39
| URL url = new URI(Constants.TOKEN_URL).toURL(); | ||
| HttpURLConnection conn = (HttpURLConnection) url.openConnection(); |
There was a problem hiding this comment.
Hier fehlt das Prüfen ob der Test Modus aktiv ist, und dann sollte die andere URL verwendet werden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.