fix: extract request-id from response headers #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulAsjes
approved these changes
Feb 10, 2025
| return | ||
| request_id = _response.headers.get('request-id') | ||
| if not request_id: | ||
| raise ApiError( |
There was a problem hiding this comment.
How likely is this to happen?
There was a problem hiding this comment.
impossible because we set it if not provided by the user
There was a problem hiding this comment.
i can just leave it as optional alternatively ?
|
please don't merge, want to leave for fern folks to see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #478
please don't merge, want to leave for fern folks to see