Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test models in the report #1697

Merged
merged 14 commits into from
Sep 12, 2024
Merged

Conversation

MikaKerman
Copy link
Contributor

@MikaKerman MikaKerman commented Sep 8, 2024

A new "tests" section in the JSON report, with pure test data, was added to make the test metadata (now called "test") accessible even when there were no runs and results.

Copy link

linear bot commented Sep 8, 2024

Copy link
Contributor

github-actions bot commented Sep 8, 2024

👋 @MikaKerman
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@MikaKerman MikaKerman force-pushed the ele-3608-test-metadata-in-the-report branch 2 times, most recently from 07faf26 to 4de1a88 Compare September 10, 2024 07:52
@MikaKerman MikaKerman marked this pull request as ready for review September 10, 2024 13:42
@@ -1,56 +0,0 @@
{% macro get_tests() %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the unused macro right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, but please double check me 🙏

@MikaKerman MikaKerman merged commit 9ac1d91 into master Sep 12, 2024
3 checks passed
@MikaKerman MikaKerman deleted the ele-3608-test-metadata-in-the-report branch September 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants