Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELE-3576: CLI - api dbtrunner save error logs #1681

Merged
merged 1 commit into from
Aug 25, 2024
Merged

ELE-3576: CLI - api dbtrunner save error logs #1681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion elementary/clients/dbt/api_dbt_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
CommandLineDbtRunner,
DbtCommandResult,
)
from elementary.clients.dbt.dbt_log import DbtLog
from elementary.exceptions.exceptions import DbtCommandError
from elementary.utils.cwd import with_chdir
from elementary.utils.env_vars_context import env_vars_context
Expand Down Expand Up @@ -40,7 +41,7 @@ def _inner_run_command(
dbt_logs = []

def collect_dbt_command_logs(event):
if event.info.name == "JinjaLogInfo":
if event.info.name in ["JinjaLogInfo", "RunningOperationCaughtError"]:
event_dump = json.dumps(MessageToDict(event)) # type: ignore[arg-type]
dbt_logs.append(event_dump)

Expand All @@ -53,6 +54,7 @@ def collect_dbt_command_logs(event):
raise DbtCommandError(
base_command_args=dbt_command_args,
err_msg=(str(res.exception) if res.exception else output),
logs=[DbtLog.from_log_line(log) for log in dbt_logs],
)

return APIDbtCommandResult(success=res.success, output=output, result_obj=res)
Expand Down
Loading