Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get current server time in milliseconds in ModuleApi #18144

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

qashlan
Copy link
Contributor

@qashlan qashlan commented Feb 9, 2025

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@qashlan qashlan marked this pull request as ready for review February 9, 2025 19:58
@qashlan qashlan requested a review from a team as a code owner February 9, 2025 19:58
Copy link
Contributor

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. I'm going to put this up for review again as #18104 was my own idea and perhaps someone else has some differing ideas.

changelog.d/18144.feature Outdated Show resolved Hide resolved
@MadLittleMods MadLittleMods requested a review from a team February 10, 2025 17:49
@MadLittleMods MadLittleMods requested a review from a team February 11, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module API: Expose clock to get current time
2 participants