-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new preview screen when tapping media on the room and pinned events screens. #3736
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3736 +/- ##
===========================================
- Coverage 78.61% 78.52% -0.09%
===========================================
Files 791 793 +2
Lines 68430 68836 +406
===========================================
+ Hits 53795 54055 +260
- Misses 14635 14781 +146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
59de737
to
71f8ffe
Compare
ElementX/Sources/Screens/MediaEventsTimelineScreen/MediaEventsTimelineScreenViewModel.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool how nicely all of this fits together! 👏
4fe21b6
to
ce00c4b
Compare
|
This enables swiping between previews on both of those screens.
The second commit tidies up the presentation logic so that all of the screens use the same logic to present a media preview.
The last commit adds pagination requests.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-04.at.15.29.23.mp4
Closes #3689
Closes #1520