Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new preview screen when tapping media on the room and pinned events screens. #3736

Merged
merged 10 commits into from
Feb 5, 2025

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 4, 2025

This enables swiping between previews on both of those screens.

The second commit tidies up the presentation logic so that all of the screens use the same logic to present a media preview.

The last commit adds pagination requests.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-04.at.15.29.23.mp4

Closes #3689
Closes #1520

@pixlwave pixlwave requested a review from a team as a code owner February 4, 2025 15:30
@pixlwave pixlwave requested review from stefanceriu and removed request for a team February 4, 2025 15:30
@pixlwave pixlwave added the pr-change for updates to an existing feature label Feb 4, 2025
@pixlwave pixlwave changed the title Use the new TimelineMediaPreview modifier on the room and pinned timeline screens. Use the new preview screen when tapping media on the room and pinned timeline screens. Feb 4, 2025
@pixlwave pixlwave changed the title Use the new preview screen when tapping media on the room and pinned timeline screens. Use the new preview screen when tapping media on the room and pinned events screens. Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 53.11573% with 158 lines in your changes missing coverage. Please review.

Project coverage is 78.52%. Comparing base (42257a1) to head (8af12b1).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../Screens/Timeline/TimelineInteractionHandler.swift 0.00% 58 Missing ⚠️
...ineScreen/MediaEventsTimelineScreenViewModel.swift 18.75% 26 Missing ⚠️
...X/Sources/Screens/Timeline/TimelineViewModel.swift 5.26% 18 Missing ⚠️
...neScreen/PinnedEventsTimelineScreenViewModel.swift 0.00% 17 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 23.52% 13 Missing ⚠️
...Screen/PinnedEventsTimelineScreenCoordinator.swift 0.00% 8 Missing ⚠️
...rdinators/MediaEventsTimelineFlowCoordinator.swift 0.00% 4 Missing ⚠️
...ePreviewScreen/TimelineMediaPreviewViewModel.swift 86.95% 3 Missing ⚠️
...ewScreen/View/TimelineMediaPreviewController.swift 0.00% 3 Missing ⚠️
...eScreen/MediaEventsTimelineScreenCoordinator.swift 0.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3736      +/-   ##
===========================================
- Coverage    78.61%   78.52%   -0.09%     
===========================================
  Files          791      793       +2     
  Lines        68430    68836     +406     
===========================================
+ Hits         53795    54055     +260     
- Misses       14635    14781     +146     
Flag Coverage Δ
unittests 70.29% <53.11%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave force-pushed the doug/room-media-swiping branch 2 times, most recently from 59de737 to 71f8ffe Compare February 5, 2025 11:29
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool how nicely all of this fits together! 👏

@pixlwave pixlwave force-pushed the doug/room-media-swiping branch from 4fe21b6 to ce00c4b Compare February 5, 2025 12:26
Copy link

sonarqubecloud bot commented Feb 5, 2025

@pixlwave pixlwave merged commit cfaa1b4 into develop Feb 5, 2025
13 checks passed
@pixlwave pixlwave deleted the doug/room-media-swiping branch February 5, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Attachment viewer: navigation by swiping left and right Infinite scrolling media gallery
2 participants