Add back pickRooms, readStateEvents and readRoomEvents #29109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those methods got deprecated but are still used in the case where the widget does not define a `set` room and also does not pass the roomId of which room it wants to read the events from in the widget action.
|
Not needed. Those are never run on EW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those methods got deprecated but are still used in the case where the widget does not
define a
setroom and also does not pass the roomId of which room it wants to readthe events from in the widget action.
I am not sure this is needed. @robintown can you confirm that on the EW widget driver implementation we should never reach widget-api code that calls those methods?
Checklist
public/exportedsymbols have accurate TSDoc documentation.