-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Recovery
section in the new user settings Encryption
tab
#28673
base: develop
Are you sure you want to change the base?
Conversation
7ee9a42
to
a90f51f
Compare
a90f51f
to
b3dc812
Compare
b3dc812
to
98d86e0
Compare
98d86e0
to
2710462
Compare
2710462
to
5e31204
Compare
5e31204
to
54ede8b
Compare
54ede8b
to
1811aa6
Compare
97b9f95
to
9aecfcc
Compare
padding: var(--cpd-space-10x); | ||
border-radius: var(--cpd-space-4x); | ||
/* From figma */ | ||
box-shadow: 0 1.2px 2.4px 0 rgba(27, 29, 34, 0.15); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be in Compound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that compound hosts box-shadow tokens
90be549
to
70375f2
Compare
70375f2
to
c805cd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot here, but lgtm as far as I can see!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, on further reading I have some questions.
}, | ||
); | ||
|
||
test("should setup the recovery key", { tag: "@screenshot" }, async ({ page, app, util }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this test be more along the lines of registering an account and then setting up recovery? Is the bot doing something here to get crypto into a certain state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can if you delete your key backup. For example go to the Security & Privacy tab and click on "Delete backup". Even if we remove this section of Security & Privacy later, an another matrix client can remove it.
The e2e test call client.getCrypto()?.deleteKeyBackupVersion(backupVersion)
on the last backup version to be in this state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, I think I was confusing this with deleteCachedSecrets()
.
Checklist
public
/exported
symbols have accurate TSDoc documentation.First of all, I'm sorry for the size of the PR.
Task #26468
Figma design
Add a new encryption tab with a new recovery section.
Implemented
The encryption tab has the following behaviour:
The recovery section has the following behaviour:
Not implemented
This PR DON'T (because the PR is already massive and theses tasks should be done in other PRs):