Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert GoToHome keyboard shortcut to Ctrl–Alt–H on macOS #28577

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Revert GoToHome keyboard shortcut to Ctrl–Alt–H on macOS #28577

wants to merge 2 commits into from

Conversation

gy-mate
Copy link

@gy-mate gy-mate commented Nov 27, 2024 •
edited
Loading

Fixes #28576 by partially reverting matrix-org/matrix-react-sdk#7631

Checklist

  • Tests written for new code (and old code if feasible). N/A
  • New or updated public/exported symbols have accurate TSDoc documentation. N/A
  • Linter and other CI checks pass.
    • Pull Request / action / Preview Changelog (pull_request_target) seems to fail only due to a missing label that I can't add.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@gy-mate gy-mate requested a review from a team as a code owner November 27, 2024 09:34
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Nov 27, 2024
@florianduros
Copy link
Member

florianduros commented Dec 24, 2024 •
edited
Loading

Hi,

The issue is specific to safari and the fix will remove the shortcut to all the others browsers on Macos (firefox, chrome...).

@gy-mate
Copy link
Author

gy-mate commented Dec 24, 2024

the fix will remove the shortcut all the others browsers on Macos (firefox, chrome...)

@florianduros Why is that? I just wanted to change the shortcut to Ctrl–Alt–H.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from element-hq/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cmd–Shift–H keyboard shortcut hijacks the Safari shortcut for Home
2 participants
@gy-mate @florianduros