Refactor CreateCrossSigningDialog #28218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Converts CreateCrossSigningDialog to a functional component * Pulls logic out to its own class * Updates usage of deprecated cross signing bootstrap method on client to be on the crypto object and updates test to match Moved from element-hq/matrix-react-sdk#131
…tecrosssigningdialog
…tecrosssigningdialog
…tecrosssigningdialog
florianduros
approved these changes
Oct 21, 2024
Comment on lines
139
to
140
| getActiveSessionBackupVersion: jest.fn().mockResolvedValue(null), | ||
| globalBlacklistUnverifiedDevices: false, |
There was a problem hiding this comment.
Why do we need to move theses two functions?
There was a problem hiding this comment.
Oh, we both added them and I probably accepted the wrong set of changes when merging.
andybalaam
approved these changes
Oct 22, 2024
Co-authored-by: Andy Balaam <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from element-hq/matrix-react-sdk#131
Checklist
public/exportedsymbols have accurate TSDoc documentation.