-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MSC4142: Remove unintentional intentional mentions in replies #28209
base: develop
Are you sure you want to change the base?
Conversation
f80ba64
to
8d654d6
Compare
Hi! The MSC has not landed yet, so I'm turning back this PR to draft. |
@florianduros the MSC being accepted requires product review here, so blocking this on the MSC landing would cause a deadlock 😅 matrix-org/matrix-spec-proposals#4142 (comment) As mentioned in the PR description, the spec already allows changing the behavior in implementations, so this can be merged before the MSC lands, but it'd also work to get product approval here first, then merge the MSC, and finally merge this PR. |
@@ -100,12 +100,6 @@ export function attachMentions( | |||
// event + any mentioned users in that event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment looks incorrect now
LGTM, but I believe @langleyd is checking this with the product folks. I don't quite agree with @tulir that rejecting this would cause a deadlock, because we don't have to merge changes in EW before an MSC can land; however, I do agree that this change is consistent with the current spec and therefore we don't need the MSC to land before we merge this. In other words, the two changes can land in either order. |
Fixes #27291
Implements matrix-org/matrix-spec-proposals#4142
Re-opened version of element-hq/matrix-react-sdk#30, which is a re-opened version of matrix-org/matrix-react-sdk#12511
The current spec is just a recommendation, so following it is not required and this can be merged already before the MSC is accepted. The goal of the MSC is to remove the dumb recommendation from the spec
For context:
In all cases, new explicit mentions are also of course included