Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ia32 Windows target #1685

Closed
wants to merge 5 commits into from
Closed

Drop ia32 Windows target #1685

wants to merge 5 commits into from

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented May 20, 2024

Fixes #1666

Discussed with product team beforehand as something we should just do at this point.

Checklist

  • Ensure your code works with manual testing.
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@Half-Shot Half-Shot requested review from a team as code owners May 20, 2024 08:49
@dosubot dosubot bot added the T-Task Tasks for the team like planning label May 20, 2024
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to communicate this to existing users. Either by creating a message in the affected users app or via deprecating publicly and setting a death date or both.

@Half-Shot
Copy link
Member Author

Half-Shot commented Oct 15, 2024

We need to communicate this to existing users. Either by creating a message in the affected users app or via deprecating publicly and setting a death date or both.

I think we could add a toast (or banner?) for users on ia32 that tells them that they will be unsupported by X date. I do think the affected user pool will be very low, but I suppose in the range of 0.01~0.1% of users.

Actually thinking a bit more abstract here, can we just have a toast for unsupported operating systems. I can imagine that this is relatively common for MacOS / Linux as we deprecated every so often?

@langleyd
Copy link
Member

@t3chguy Can the toast we have for unsupported browsers be easily built upon for unsupported OSes?

@t3chguy
Copy link
Member

t3chguy commented Oct 15, 2024

Perhaps but then you'd risk impacting a community maintained package for ia32, this would need to be a warning only for users of our own package surely

@langleyd
Copy link
Member

@Half-Shot Is updating adding the upsupported OS toast(similar to the unupported browser one) something you would be able to take a look at as a part of this?

@Half-Shot
Copy link
Member Author

@Half-Shot Is updating adding the upsupported OS toast(similar to the unupported browser one) something you would be able to take a look at as a part of this?

Pragmatically, I don't think I've got enough time on my hands to work on that. I do think it would be useful for now and in the future, but presently I'm overbooked.

@t3chguy
Copy link
Member

t3chguy commented Nov 14, 2024

Marking as draft until it is iterated upon so it doesn't keep coming back up in our weekly calls

@t3chguy t3chguy marked this pull request as draft November 14, 2024 10:33
@richvdh
Copy link
Member

richvdh commented Nov 14, 2024

Rather than add to the backlog of draft PRs, I'm going to close this for now.

We'd love to see this work done, but it seems nobody has time to bring it to completion. If anybody (@Half-Shot or otherwise) can take it on, we'd be delighted to reopen the PR!

@richvdh richvdh closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we still need to build for ia32 (Windows)?
4 participants