Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering text replies #8947

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix rendering text replies #8947

merged 1 commit into from
Dec 20, 2024

Conversation

tulir
Copy link
Contributor

@tulir tulir commented Nov 18, 2024

Reply fallbacks are about to go away completely (matrix-org/matrix-spec-proposals#2781, element-hq/element-web#28406) and Element will probably get a lot of complaints if rendering replies doesn't work correctly. According to @AmineI (in #8162 (comment)) just switching formattedText to takeFormatted() may resolve the issue for text replies.

I haven't tested this myself. If the fix works, I assume the problem is that element was assuming formatted_body is always present, even though it's not required. To test: send /plain text as a reply using develop.element.io and ensure both the quote and reply text are visible in element android (the /plain should prevent formatted_body being added to the message).

Fixes #7445
Fixes #8162
Fixes #8460
Fixes #8866

Image replies will remain broken (#8432, #6570)

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 9dfc1f1 into element-hq:develop Dec 20, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants