Make DefaultMdmService a singleton and use Binds instead of Provides.

element-hq · Dec 4, 2023 · 6452b5c · 6452b5c
1 parent 882020f
commit 6452b5c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/vector-app/src/main/java/im/vector/app/core/di/SingletonModule.kt b/vector-app/src/main/java/im/vector/app/core/di/SingletonModule.kt
@@ -111,6 +111,9 @@ import javax.inject.Singleton
     @Binds
     abstract fun bindEmojiSpanify(emojiCompatWrapper: EmojiCompatWrapper): EmojiSpanify
 
+    @Binds
+    abstract fun bindMdmService(service: DefaultMdmService): MdmService
+
     @Binds
     abstract fun bindFontScale(fontScale: FontScalePreferencesImpl): FontScalePreferences
 
@@ -173,11 +176,6 @@ import javax.inject.Singleton
         return Matrix(context, configuration)
     }
 
-    @Provides
-    fun providesMdmService(context: Context): MdmService {
-        return DefaultMdmService(context)
-    }
-
     @Provides
     fun providesCurrentSession(activeSessionHolder: ActiveSessionHolder): Session {
         // TODO handle session injection better

diff --git a/vector/src/main/java/im/vector/app/features/mdm/DefaultMdmService.kt b/vector/src/main/java/im/vector/app/features/mdm/DefaultMdmService.kt
@@ -25,7 +25,9 @@ import androidx.core.content.getSystemService
 import dagger.hilt.android.qualifiers.ApplicationContext
 import timber.log.Timber
 import javax.inject.Inject
+import javax.inject.Singleton
 
+@Singleton
 class DefaultMdmService @Inject constructor(
         @ApplicationContext applicationContext: Context
 ) : MdmService {