remake vector_set from inheritance from underlying container to aggre… #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonYudintsev
force-pushed
the
refactor_vector_set
branch
7 times, most recently
from
53d4902
to
31d3905
Compare
AntonYudintsev
force-pushed
the
refactor_vector_set
branch
from
31d3905
to
f57ef34
Compare
…gation this makes it safer, as it disallows some of changes that could violate sorted contract it also saves at least sizeof(void*) on most common comparators (due to empty struct optimization in compressed_pair) con: it explicitly requires container class to follow vector API (almost all functions are exposed in vector_set) to consider: remove non const front(), back(), at(), [] access. Those are not safe either, left them only for compatibility
AntonYudintsev
force-pushed
the
refactor_vector_set
branch
from
f57ef34
to
2fe435b
Compare
|
Hello, We actually have an internal change in progress (unreleased as of this writing) to reduce the size of |
|
Hello again, Version 3.21.12 (#510) has the changes we had in progress that I mentioned above. Let me know if you want to try to rebase on the new version to try to get some of the API/inheritance changes reviewed or if we should close this PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gation
this makes it safer, as it disallows some of changes that could violate sorted contract it also saves at least sizeof(void*) on most common comparators (due to empty struct optimization in compressed_pair)
con: it explicitly requires container class to follow vector API (almost all functions are exposed in vector_set)
to consider: remove non const front(), back(), at(), [] access. Those are not safe either, left them only for compatibility