variant constructor and assignment shouldn't allow narrow conversion #463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the standard, the constructor of a variant should construct a variant holding an alternative type T_i from an input of type T only if no narrow conversion is performed between T and T_i.
See documentation here: https://en.cppreference.com/w/cpp/utility/variant/variant
Constructor 4:
As a direct consequence, the following code is valid (taken from the link above):