Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): use tsx for build scripts #569

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix(build): use tsx for build scripts #569

merged 2 commits into from
Jun 4, 2024

Conversation

erickzhao
Copy link
Member

I removed the ts-node dependency in #563, but forgot that we have a bunch of scripts that rely on being run with that package. 🤦

Unfortunately, the move to ES Modules for various packages we rely on made it impossible to just revert the config.

I ran into some issues despite running with the --esm flag, and there seem to be some upstream issues with ts-node and Node 20: TypeStrong/ts-node#1997

I tried tsx as a drop-in replacement and it seems to work like a charm.

Note that this PR seems to have updated a bunch of docs via the pre-build script. I don't know why changes didn't pick this up before, but it seems like all these formatting changes the double whitespaces are present upstream. Might be related to the Remark-related package upgrades from the Docusaurus 3 upgrade.

@erickzhao erickzhao requested a review from dsanders11 June 3, 2024 22:33
@erickzhao erickzhao marked this pull request as ready for review June 3, 2024 22:33
@erickzhao erickzhao requested a review from a team as a code owner June 3, 2024 22:33
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-569 June 3, 2024 22:33 Inactive
@erickzhao erickzhao merged commit f08be77 into main Jun 4, 2024
4 checks passed
@erickzhao erickzhao deleted the use-tsx branch June 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants