-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wg-ecosystem): add Node version policy and cleanup #578
Conversation
wg-ecosystem/README.md
Outdated
As of July 2024, our current plan is to upgrade all packages to a minimum of Node.js 22 when that version | ||
reaches its LTS date ([see Node.js release schedule for more details](https://nodejs.org/en/about/previous-releases#release-schedule)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we were also discussing jumping to 20.x if the ESM changes are backported. If we do 22 we'll probably want to wait N months after LTS rather than jumping to it right after it reaches LTS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah maybe avoid specifying the version, say "the first LTS version with require-esm support" or something and link the node issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -6,19 +6,19 @@ Oversees the projects that make Electron app development easier. | |||
|
|||
| Avatar | Name | Role | Time Zone | | |||
| -------------------------------------------|----------------------|----------------------------| -------- | | |||
| <img src="https://github.com/blackhole1.png" width=100 alt="@blackhole1"> | Black-Hole [@blackhole1](https://github.com/blackhole1) | Member | BJT (Hangzhou) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing the order here? It was order-joined originally which was kinda nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already alphabetized by GitHub username for everyone else but our most recent members added themselves at the bottom so I kind of fixed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, considering I was second in the list. 😅
@@ -60,10 +60,7 @@ These projects are sorted alphabetically, their order does not reflect that any | |||
* Update server (update.electronjs.org) | |||
* Windows Installer (`electron-winstaller`) | |||
* Tools (Userland) | |||
* Devtron | |||
* electron-compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never 4get
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rip end of an era
wg-ecosystem/README.md
Outdated
As of July 2024, our current plan is to upgrade all packages to a minimum of Node.js 22 when that version | ||
reaches its LTS date ([see Node.js release schedule for more details](https://nodejs.org/en/about/previous-releases#release-schedule)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah maybe avoid specifying the version, say "the first LTS version with require-esm support" or something and link the node issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like what we did in fact discuss
As discussed in today's meeting :)