Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wg-ecosystem): add Node version policy and cleanup #578

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

erickzhao
Copy link
Member

As discussed in today's meeting :)

@erickzhao erickzhao marked this pull request as ready for review July 24, 2024 03:07
@erickzhao erickzhao requested a review from a team as a code owner July 24, 2024 03:07
Comment on lines 129 to 130
As of July 2024, our current plan is to upgrade all packages to a minimum of Node.js 22 when that version
reaches its LTS date ([see Node.js release schedule for more details](https://nodejs.org/en/about/previous-releases#release-schedule)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we were also discussing jumping to 20.x if the ESM changes are backported. If we do 22 we'll probably want to wait N months after LTS rather than jumping to it right after it reaches LTS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah maybe avoid specifying the version, say "the first LTS version with require-esm support" or something and link the node issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -6,19 +6,19 @@ Oversees the projects that make Electron app development easier.

| Avatar | Name | Role | Time Zone |
| -------------------------------------------|----------------------|----------------------------| -------- |
| <img src="https://github.com/blackhole1.png" width=100 alt="@blackhole1"> | Black-Hole [@blackhole1](https://github.com/blackhole1) | Member | BJT (Hangzhou) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing the order here? It was order-joined originally which was kinda nice

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already alphabetized by GitHub username for everyone else but our most recent members added themselves at the bottom so I kind of fixed that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, considering I was second in the list. 😅

@@ -60,10 +60,7 @@ These projects are sorted alphabetically, their order does not reflect that any
* Update server (update.electronjs.org)
* Windows Installer (`electron-winstaller`)
* Tools (Userland)
* Devtron
* electron-compile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never 4get

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rip end of an era

Comment on lines 129 to 130
As of July 2024, our current plan is to upgrade all packages to a minimum of Node.js 22 when that version
reaches its LTS date ([see Node.js release schedule for more details](https://nodejs.org/en/about/previous-releases#release-schedule)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah maybe avoid specifying the version, say "the first LTS version with require-esm support" or something and link the node issue

Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like what we did in fact discuss

@erickzhao erickzhao merged commit 3db8c9c into main Jul 25, 2024
2 checks passed
@erickzhao erickzhao deleted the erickzhao-patch-2 branch July 25, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants