Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-wix): set default arch #3859

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 19, 2025

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

electron-wix-msi defaults to x86 arch.

Even if @electron-forge is set to make x64 installer, by default x86 installer will be created, and the app will be installed to C:\Program Files (x86)\.

⚠️ Note: this might be considered a breaking change - new installation will be in a new directory (C:\Program Files\ after C:\Program Files (x86)\).

Alternative: maker users can manually pass arch.

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme requested a review from a team as a code owner February 19, 2025 22:17
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I think you're right about this being a breaking change, but I think building according to the arch makes the most sense according to how we normally output Forge distributables.

I'm a +1 for this, but only merging after we start the Forge 8 release process.

@erickzhao erickzhao marked this pull request as draft February 20, 2025 01:51
@erickzhao erickzhao added this to the 8.0.0 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants