fix: preserve macos child window level

[JoelEinbinder]

Description of Change

There is some code in Chromium that checks the window level to determine if an unfocused window can receive mousemove events.

When Electron sets a window's parent, the level of both the parent and child are reset to NSWindowNormal. There is already some code to restore the parent's level. So I added some code to restore the child's level as well.

If the current behavior is the intended behavior, then an alternative patch could add a new window property that overrides the level check in Chromium. But this seemed simpler to me.

I couldn't find any tests for this area of the code. Happy to let someone with more Electron knowledge take over from here if much more is needed to get this landed.

Fixes #44150

Release Notes

Notes: Fixed MacOS windows losing their alwaysOnTop status when they were assigned a parent window.

[welcome]

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codebytere]

@JoelEinbinder could you try to add a test for this? Beyond that LGTM!

[JoelEinbinder]

@JoelEinbinder could you try to add a test for this? Beyond that LGTM!

I can write a test except I don't know where a test for this would live. I tried to look for examples but there was no test in the previous patches that restored the parents level (af4cf1e) and the one that added panels (21ef850).

[codebytere]

@joel I'd say this should live in browser-window spec - you can just add a new describe. Also, can you please sign your commit?

[codebytere]

@JoelEinbinder If you rebase this and sign your commit, I can try to add a test myself

[tilemanrenovations]

My bad I got several things going this morning I’ll run it shortly. Thanks again. Get Outlook.vip for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Shelley Vohr ***@***.***> Sent: Wednesday, October 30, 2024 5:42:12 AM To: electron/electron ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [electron/electron] fix: preserve macos child window level (PR #44155) @JoelEinbinder<https://github.com/JoelEinbinder> If you rebase this and sign your commit, I can try to add a test myself — Reply to this email directly, view it on GitHub<#44155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A6YMX4CBYVG5F7X2WSMNPKDZ6CZYJAVCNFSM6AAAAABPTRDEL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWGUYTOMJZGA>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[JoelEinbinder]

Sorry I've been far away from my computer that compiles Chromium. I'll be back in about a week and take another look at this.