Skip to content

feat: add excludeReBuildModules option to configuration and scheme #9097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

beyondkmp
Copy link
Collaborator

Introduced a new configuration option excludeReBuildModules to allow users to specify modules that should be excluded from the rebuild process. This option is now available in the CommonConfiguration and PlatformSpecificBuildOptions interfaces, as well as in the scheme.json file.

Introduced a new configuration option `excludeReBuildModules` to allow users to specify modules that should be excluded from the rebuild process. This option is now available in the `CommonConfiguration` and `PlatformSpecificBuildOptions` interfaces, as well as in the scheme.json file.
Copy link

changeset-bot bot commented May 12, 2025

⚠️ No Changeset found

Latest commit: 4a6fa50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mmaietta
Copy link
Collaborator

Is this solving for a currently-existing issue?

Also wondering if we should put this in the next major semver bump so as to reorganize all native-rebuilding logic (npmRebuild, buildDependenciesFromSource, etc.) into a single property called nativeRebuild or potentially more accurately put electronRebuild

@beyondkmp
Copy link
Collaborator Author

beyondkmp commented May 12, 2025

Is this solving for a currently-existing issue?

Yes, but that person didn't create an issue — he asked me directly. He has a prebuilt package and doesn't want to recompile it, as it takes a lot of time, but he still wants to compile the other native packages. He mentioned that Electron Forge has such a configuration, but Electron Builder does not.

Also wondering if we should put this in the next major semver bump so as to reorganize all native-rebuilding logic (npmRebuild, buildDependenciesFromSource, etc.) into a single property called nativeRebuild or potentially more accurately put electronRebuild

Agree to put this in the next major semver.

@mmaietta
Copy link
Collaborator

@beyondkmp do you mind if I pick this up? I'd like to do a little refactoring and typescript magic with the electron/rebuild integration.

Quick side note though, next major semver is also the migration to ESM-only

@beyondkmp
Copy link
Collaborator Author

@mmaietta Not at all. Feel free to at me anytime if you need help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants