-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: add excludeReBuildModules option to configuration and scheme #9097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Introduced a new configuration option `excludeReBuildModules` to allow users to specify modules that should be excluded from the rebuild process. This option is now available in the `CommonConfiguration` and `PlatformSpecificBuildOptions` interfaces, as well as in the scheme.json file.
|
Is this solving for a currently-existing issue? Also wondering if we should put this in the next major semver bump so as to reorganize all native-rebuilding logic (npmRebuild, buildDependenciesFromSource, etc.) into a single property called |
Yes, but that person didn't create an issue — he asked me directly. He has a prebuilt package and doesn't want to recompile it, as it takes a lot of time, but he still wants to compile the other native packages. He mentioned that Electron Forge has such a configuration, but Electron Builder does not.
Agree to put this in the next major semver. |
@beyondkmp do you mind if I pick this up? I'd like to do a little refactoring and typescript magic with the electron/rebuild integration. Quick side note though, next major semver is also the migration to ESM-only |
@mmaietta Not at all. Feel free to at me anytime if you need help. |
Introduced a new configuration option
excludeReBuildModules
to allow users to specify modules that should be excluded from the rebuild process. This option is now available in theCommonConfiguration
andPlatformSpecificBuildOptions
interfaces, as well as in the scheme.json file.