Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esp32c3 #20

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Esp32c3 #20

wants to merge 1 commit into from

Conversation

faldor20
Copy link

@faldor20 faldor20 commented Apr 3, 2023

Added support for esp32c3 board

@faldor20
added esp32c3 support
27ec477 
fix issue with incorrect pin
@faldor20 faldor20 changed the base branch from master to devel April 3, 2023 12:51
elcritch
elcritch reviewed Jul 23, 2024
View reviewed changes
src/nesper/esp/driver/esp32/io_mux_reg.nim
@@ -1,6 +1,7 @@
###
# ESP32 specific io_mux_reg.h port
##
arsoienieonrstg
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

src/nesper/esp/driver/esp32c3/io_mux_reg.h
@@ -0,0 +1,551 @@
/*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file?

src/nesper/esp/driver/esp32c3/io_mux_reg.nim

const hdr = "soc/io_mux_reg.h"

var SLP_OE* {.importcpp: "SLP_OE", header: hdr.}: int
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's a new option which is to use let. Also, these should use importc?

Suggested change
var SLP_OE* {.importcpp: "SLP_OE", header: hdr.}: int
let SLP_OE* {.importc: "SLP_OE", header: hdr.}: int

src/nesper/esp/driver/io_mux_reg.nim
when defined(esp32s3):
include ./esp32s3/io_mux_reg
elif defined(esp32c3):
include ./esp32c3/io_mux_reg
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this pattern appears to be working well.

@elcritch
Copy link
Owner

@faldor20 heya I reviewed this last year but forgot to submit the review. This still looks alright to me, pending my comments.

@faldor20
Copy link
Author

Hey, I'm probably never going to get to this, I don't actually use nim for anything these days and it's been well over a year since I last even had it installed. You're welcome to take it over and merge it though :)

@elcritch
Copy link
Owner

Hey, I'm probably never going to get to this, I don't actually use nim for anything these days and it's been well over a year since I last even had it installed. You're welcome to take it over and merge it though :)

That's too bad, but thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcritch elcritch elcritch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faldor20 @elcritch