User and password authentication #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elchicodepython
requested changes
Sep 19, 2022
| raise ValueError("Either сredentials or token must be provided") | ||
|
|
||
| if not auth_token and (email and password): | ||
| auth_token = JWTAuthToken(self.get_auth_token(email, password)) |
There was a problem hiding this comment.
I'm not sure about having a HTTP request in the NocoDBRequestsClient initialization. I suggest creating a class with the purpose of retrieving the AuthToken.
classDiagram
class NocoDBAuthClient {
<< interface >>
+get_auth_token() AuthToken
}
class NocoDBAuthRequestsClient {
+get_auth_token() AuthToken
}
NocoDBAuthClient <|-- NocoDBAuthRequestsClient
Usage example:
auth_client = NocoDBAuthRequestsClient("username", "password")
auth_token = auth_client.get_auth_token()
client = NocoDBRequestsClient(base_uri, auth_token)| self.__session.headers.update( | ||
| auth_token.get_header(), | ||
| ) | ||
| auth_token.get_header(), |
There was a problem hiding this comment.
This change has nothing to do with the commit.
Suggested change
| auth_token.get_header(), | |
| auth_token.get_header(), |
elchicodepython
force-pushed
the
master
branch
from
39a678d to
7a739e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.