Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection time TLS SNI support #498

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mixcode
Copy link

@mixcode mixcode commented Feb 21, 2023

TLSConfigFromCA() changed to return a config with run-time signing function to properly support TLS Server Name Indication.
Also, a small glitch regarding host name string is fixed.

@ErikPelli
Copy link
Collaborator

Why should we overwrite the host (which is obtained using r.URL.Host) with the ClientHello value?
We already know the host, this seems not useful to me.
Is there any specific case that you are trying to solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants