Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: check amount of logs in reviews #981

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

Eliastisys
Copy link
Contributor

⚠️ IMPORTANT ⚠️: This is a public repository. Make sure to not disclose:

  • personal data beyond what is necessary for interacting with this Pull Request;
  • business confidential information, such as customer names.

Quality gates:

  • I'm aware of the Contributor Guide and did my best to follow the guidelines.
  • I'm aware of the Glossary and did my best to use those terms.

what/why

Small update to the log review process to potentially catch excessive amount of logs. This could as an example help us update our audit log policy instead of scaling up a bunch of Opensearch volumes.

Copy link
Contributor

@simonklb simonklb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a simple instruction that you could include on how you check the size or is that obvious in the UI?

docs/ciso-guide/log-review.md Outdated Show resolved Hide resolved
@Eliastisys
Copy link
Contributor Author

Eliastisys commented Oct 30, 2024

Is there a simple instruction that you could include on how you check the size or is that obvious in the UI?

@simonklb it's easy to see the amount in the UI but maybe worth clarifying to set the time interval bigger than retention (30 days)?

Copy link
Contributor

@AlbinB97 AlbinB97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Collaborator

@cristiklein cristiklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Eliastisys Eliastisys merged commit 7a46d02 into main Nov 7, 2024
1 check passed
@Eliastisys Eliastisys deleted the eliash/log-review-update branch November 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants