Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adr-0036: Add as benefit the use of externalTrafficPolicy=local #978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adr-0036: Add as benefit the use of externalTrafficPolicy=local #978

wants to merge 1 commit into from

Conversation

lucianvlad
Copy link
Contributor

⚠️ IMPORTANT ⚠️: This is a public repository. Make sure to not disclose:

  • personal data beyond what is necessary for interacting with this Pull Request;
  • business confidential information, such as customer names.

Quality gates:

  • I'm aware of the Contributor Guide and did my best to follow the guidelines.
  • I'm aware of the Glossary and did my best to use those terms.

@lucianvlad lucianvlad requested review from cristiklein, Xartos and a team October 18, 2024 15:35
@lucianvlad lucianvlad self-assigned this Oct 18, 2024
@lucianvlad lucianvlad requested a review from a team as a code owner October 18, 2024 15:35
cristiklein
cristiklein approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@cristiklein cristiklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this small, but important addition.

OlleLarsson
OlleLarsson reviewed Oct 21, 2024
View reviewed changes
docs/adr/0036-run-ingress-nginx-as-daemonset.md
@@ -44,6 +44,7 @@ Chosen options: 1 & 3 & 5
- No changes are needed.
- More resources are available on the AMS nodes.
- Reduce complexity.
- We will now use `externalTrafficPolicy: local` and with this we will reduce latency and preserve the client’s source IP address, which is essential for some applications that rely on knowing the client's IP, such as for logging, security, or geolocation services.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of moving it to Recommendation to Platform Administrators and reword it a little bit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not I would say that we should reword it to something along the lines of

externalTrafficPolicy can be set to local which can reduce latency and preserve the client's source IP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to have it by default set to local so the can be se to 'local' ... sounds a bit strange since we did this by default now in apps #2317
What is your thought on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like more of an action than a positive consequence of the chosen option(s), but I'm not too bothered. Merge if you are happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlleLarsson OlleLarsson OlleLarsson left review comments

@Xartos Xartos Xartos approved these changes

@cristiklein cristiklein cristiklein approved these changes

Assignees

@lucianvlad lucianvlad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucianvlad @cristiklein @Xartos @OlleLarsson