-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adr-0054 Allow Application Developer write access to Endpoints and EndpointSlices after Proper Risk Acceptance #964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please increment the adr number as now we have 2 adr's with 0053
- adr:0053 Observability data for platform services
- adr-0053: Allowance of low vulnerability CVEs
Agreed, corrected :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool that we catch up with ADRs! I really value that we systematically capture complex discussion in a way that ensure internal and external alignment.
I see two high-level issues with this ADR:
First, this feels way too broad and risk sending the wrong message to people outside the project. This ADR should only address Endpoints and EndpointSlices.
Can you downscope the ADR accordingly?
Second, the decision should really include "after Proper Risk Acceptance" already in the title, as we did with Only allow Ingress Configuration Snippet Annotations after Proper Risk Acceptance.
Can you adjust the ADR accordingly?
Thanks!
Thanks @cristiklein I agree with you :) , It makes sense to limit to Endpoints and EndpointSlices after Proper Risk Acceptance. I have updated the ADR accordingly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads better now, but I made a few suggestions for how to make it shine. 😄
Thanks!
2cf6827
to
a9f4d6d
Compare
Thanks @cristiklein I updated the ADR accordingly :) |
64a37c5
to
c08f39c
Compare
…ndpointSlices after Proper Risk Acceptance
c08f39c
to
3c1ad76
Compare
Quality gates: