Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adr-0054 Allow Application Developer write access to Endpoints and EndpointSlices after Proper Risk Acceptance #964

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

raviranjanelastisys
Copy link
Contributor

@raviranjanelastisys raviranjanelastisys commented Sep 16, 2024

⚠️ IMPORTANT ⚠️: This is a public repository. Make sure to not disclose:

  • personal data beyond what is necessary for interacting with this Pull Request;
  • business confidential information, such as customer names.

Quality gates:

  • I'm aware of the Contributor Guide and did my best to follow the guidelines.
  • I'm aware of the Glossary and did my best to use those terms.

Copy link
Contributor

@lucianvlad lucianvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment the adr number as now we have 2 adr's with 0053

  • adr:0053 Observability data for platform services
  • adr-0053: Allowance of low vulnerability CVEs

@raviranjanelastisys raviranjanelastisys changed the title adr-0053: Allowance of low vulnerability CVEs adr-0054: Allowance of low vulnerability CVEs Sep 17, 2024
@raviranjanelastisys
Copy link
Contributor Author

Please increment the adr number as now we have 2 adr's with 0053

  • adr:0053 Observability data for platform services
  • adr-0053: Allowance of low vulnerability CVEs

Agreed, corrected :)

@raviranjanelastisys raviranjanelastisys changed the title adr-0054: Allowance of low vulnerability CVEs adr-0054 Allowance of low vulnerability CVEs Sep 17, 2024
Copy link
Collaborator

@cristiklein cristiklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that we catch up with ADRs! I really value that we systematically capture complex discussion in a way that ensure internal and external alignment.

I see two high-level issues with this ADR:

First, this feels way too broad and risk sending the wrong message to people outside the project. This ADR should only address Endpoints and EndpointSlices.

Can you downscope the ADR accordingly?

Second, the decision should really include "after Proper Risk Acceptance" already in the title, as we did with Only allow Ingress Configuration Snippet Annotations after Proper Risk Acceptance.

Can you adjust the ADR accordingly?

Thanks!

@raviranjanelastisys
Copy link
Contributor Author

Can you downscope the ADR accordingly?

Thanks @cristiklein I agree with you :) , It makes sense to limit to Endpoints and EndpointSlices after Proper Risk Acceptance. I have updated the ADR accordingly :)

Copy link
Collaborator

@cristiklein cristiklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads better now, but I made a few suggestions for how to make it shine. 😄

Thanks!

docs/adr/0054-allow-low-vulnerability-cve.md Outdated Show resolved Hide resolved
docs/adr/0054-allow-low-vulnerability-cve.md Outdated Show resolved Hide resolved
docs/adr/0054-allow-low-vulnerability-cve.md Outdated Show resolved Hide resolved
docs/adr/0054-allow-low-vulnerability-cve.md Outdated Show resolved Hide resolved
docs/adr/0054-allow-low-vulnerability-cve.md Outdated Show resolved Hide resolved
@raviranjanelastisys
Copy link
Contributor Author

This reads better now, but I made a few suggestions for how to make it shine. 😄

Thanks!

Thanks @cristiklein I updated the ADR accordingly :)
@lucianvlad Looks like your approval is needed before merge too :)

docs/adr/index.md Outdated Show resolved Hide resolved
@raviranjanelastisys raviranjanelastisys changed the title adr-0054 Allowance of low vulnerability CVEs adr-0054 Allow Application Developer write access to Endpoints and EndpointSlices after Proper Risk Acceptance Sep 18, 2024
@raviranjanelastisys raviranjanelastisys force-pushed the rranjan/adr-0054 branch 2 times, most recently from 64a37c5 to c08f39c Compare September 18, 2024 18:54
@raviranjanelastisys raviranjanelastisys merged commit 39b5d31 into main Sep 23, 2024
1 check passed
@raviranjanelastisys raviranjanelastisys deleted the rranjan/adr-0054 branch September 23, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants