Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: self-managed-CRDs #660

Merged
merged 1 commit into from
Oct 12, 2023
Merged

docs: self-managed-CRDs #660

merged 1 commit into from
Oct 12, 2023

Conversation

robinAwallace
Copy link
Contributor

Add public docs for self-managed CRDs, part of this PR.

Copy link
Contributor

@llarsson llarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a bunch of corrections and suggestions, please take a look 😄

docs/operator-manual/user-manged-crds.md Outdated Show resolved Hide resolved
docs/operator-manual/user-manged-crds.md Outdated Show resolved Hide resolved
docs/operator-manual/user-manged-crds.md Outdated Show resolved Hide resolved
docs/operator-manual/user-manged-crds.md Outdated Show resolved Hide resolved
docs/user-guide/self-managed-services/_common-crds.include Outdated Show resolved Hide resolved
docs/user-guide/self-managed-services/sealedsecrets.md Outdated Show resolved Hide resolved
docs/user-guide/self-managed-services/sealedsecrets.md Outdated Show resolved Hide resolved
docs/user-guide/self-managed-services/sealedsecrets.md Outdated Show resolved Hide resolved
docs/user-guide/self-managed-services/sealedsecrets.md Outdated Show resolved Hide resolved
docs/user-guide/self-managed-services/sealedsecrets.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@cristiklein cristiklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ I can't believe we managed to pull this off. I can only imagine how much complexity is behind, but at the surface a lot of that is abstracted away. Awesome!

I suggested some "make-up". Please review and merge when happy.

docs/operator-manual/user-manged-crds.md Outdated Show resolved Hide resolved
docs/operator-manual/user-manged-crds.md Outdated Show resolved Hide resolved
docs/operator-manual/user-manged-crds.md Outdated Show resolved Hide resolved
docs/operator-manual/user-manged-crds.md Show resolved Hide resolved
@llarsson
Copy link
Contributor

llarsson commented Sep 5, 2023

Really excited about this one! 🎉 It opens up so many wonderful possibilities (as can be seen by how many issues I've made that reference this PR 😅)

@robinAwallace
Copy link
Contributor Author

@llarsson @cristiklein if you are happy with the final changes I will merge this.

@cristiklein
Copy link
Collaborator

@robinAwallace 🚀 from my side.

@llarsson
Copy link
Contributor

Can/should we make it so that this only shows up once we have the possibility to roll this out with a new Apps release?

@llarsson
Copy link
Contributor

...we do have version specifiers on the docs, these days, so I figured it's weird if this documents something that is "upcoming", unless it's clear about doing so.

@robinAwallace
Copy link
Contributor Author

I can wait until v0.33 is released, as this should be part of v0.34. Then this will just be shown on main (which is true) and v0.34.

@robinAwallace robinAwallace force-pushed the rw/user-crds branch 2 times, most recently from 0d123d6 to 7114533 Compare September 29, 2023 08:43
@robinAwallace robinAwallace merged commit 7c787c5 into main Oct 12, 2023
1 check passed
@robinAwallace robinAwallace deleted the rw/user-crds branch October 12, 2023 08:40
@cristiklein
Copy link
Collaborator

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants