feat: bump playwright to 1.40.1 and update formatter (#871)

elastic · Dec 6, 2023 · d01c3fd · d01c3fd
1 parent d33d899
commit d01c3fd
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 38 deletions.
diff --git a/__tests__/options.test.ts b/__tests__/options.test.ts
@@ -66,7 +66,7 @@ describe('options', () => {
         ignoreHTTPSErrors: undefined,
         isMobile: true,
         userAgent:
-          'Mozilla/5.0 (Linux; Android 8.0.0; SM-G965U Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.5938.62 Mobile Safari/537.36',
+          'Mozilla/5.0 (Linux; Android 8.0.0; SM-G965U Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.6099.28 Mobile Safari/537.36',
         viewport: {
           height: 658,
           width: 320,

diff --git a/bundles/package-lock.json b/bundles/package-lock.json
diff --git a/bundles/package.json b/bundles/package.json
@@ -8,6 +8,6 @@
     "build": "npm run bundle -- --minify"
   },
   "dependencies": {
-    "playwright": "=1.38.1"
+    "playwright": "=1.40.1"
   }
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -51,9 +51,9 @@
     "kleur": "^4.1.5",
     "micromatch": "^4.0.5",
     "pirates": "^4.0.5",
-    "playwright": "=1.38.1",
-    "playwright-chromium": "=1.38.1",
-    "playwright-core": "=1.38.1",
+    "playwright": "=1.40.1",
+    "playwright-chromium": "=1.40.1",
+    "playwright-core": "=1.40.1",
     "semver": "^7.5.4",
     "sharp": "^0.32.6",
     "snakecase-keys": "^4.0.1",

diff --git a/src/formatter/javascript.ts b/src/formatter/javascript.ts
@@ -101,23 +101,15 @@ function toAssertCall(pageAlias: string, action: Action) {
 }
 
 function toSignalMap(action: Action) {
-  let waitForNavigation: Signal | undefined;
-  let assertNavigation: Signal | undefined;
   let popup: Signal | undefined;
   let download: Signal | undefined;
   let dialog: Signal | undefined;
   for (const signal of action.signals) {
-    if (signal.name === 'navigation' && signal.isAsync)
-      waitForNavigation = signal;
-    else if (signal.name === 'navigation' && !signal.isAsync)
-      assertNavigation = signal;
-    else if (signal.name === 'popup') popup = signal;
+    if (signal.name === 'popup') popup = signal;
     else if (signal.name === 'download') download = signal;
     else if (signal.name === 'dialog') dialog = signal;
   }
   return {
-    waitForNavigation,
-    assertNavigation,
     popup,
     download,
     dialog,
@@ -280,8 +272,7 @@ export class SyntheticsGenerator extends JavaScriptLanguageGenerator {
     if (isAssert && action.command) {
       formatter.add(toAssertCall(pageAlias, action));
     } else {
-      const actionCall = super._generateActionCall(action);
-      formatter.add(`await ${subject}.${actionCall};`);
+      formatter.add(super._generateActionCall(subject, action));
     }
 
     if (signals.popup)