-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add SNAPSHOT postfix when CI executes the 'snapshot' workflow type #16912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💚 Build Succeeded
cc @andsel |
@andsel I kicked off a build of the exhaustive test suite using this PR just to be on the safe side: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1144 |
Do we want the same addition in the plugin API? https://github.com/elastic/logstash/blob/main/logstash-core-plugin-api/logstash-core-plugin-api.gemspec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several use cases that need to be tested but some don't seem to work:
- tarball name contains SNAPSHOT twice 🔴
- snapshot shows up in
bin/logstash -V
🟢 - snapshot does not showsup in
bin/logstash --debug -V
, just shows 9.0.0 🔴 - snapshot shows up in HTTP api response 🟢 (there is a separate "snapshot" field in the response)
- snapshot does not show up in logging entry at startup, only 9.0.0 🔴
Also I suggest using RELEASE as the environment variable to know if the build is a release or a snapshot. WORKFLOW_TYPE is used by the ci scripts.
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
|
Superseded by #16904 |
Release notes
[rn:skip]
What does this PR do?
Updates the gemspec processing for logstash-core to include
-SNAPSHOT
whenWORKFLOW_TYPE
environment variable issnapshot
, which happens when CI builds snapshot artifacts.Why is it important/What is the impact to the user?
When running Logstash, the version stage or qualifier must be immediately visible, for example:
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Export
WORKFLOW_TYPE
tosnapshot
and verify that the started Logstash print the version with the -SNAPSHOT postfix.Related issues