-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for 8.15.4 #16611
Release notes for 8.15.4 #16611
Conversation
docs/static/releasenotes.asciidoc
Outdated
[[notable-8.15.4]] | ||
==== Notable issues fixed | ||
|
||
* Fixed an issue where Logstash could not consume lines correctly when the input buffer was full while utilizing a codec with a delimiter https://github.com/elastic/logstash/pull/16482[#16482] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andsel Does this line properly describe the bugfix of BufferedTokenizer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me seem great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we consider this:
"Fixed an issue where Logstash could not consume lines correctly when a codec with a delimiter is in use and the input buffer becomes full."
This suggestion puts the more permanent condition first (codec with a delimiter) and the more transitional condition (buffer fills up) later. Will this approach work, or does this change the meaning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works. Applied the suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor suggestions to consider for consistency and easier reading. Otherwise, LGTM! Thank you.
Co-authored-by: Karen Metts <[email protected]>
Co-authored-by: Karen Metts <[email protected]>
@logstashmachine backport 8.16 |
No description provided.