Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting/Server] register plugin routes synchronously #68976

Merged
merged 15 commits into from
Jun 15, 2020
+262 −234
Merged

[Reporting/Server] register plugin routes synchronously #68976

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8eef541
register routes synchronously
tsullivan Jun 11, 2020
26abb7d
back out some refactoring
tsullivan Jun 12, 2020
8f381a7
comment fix
tsullivan Jun 12, 2020
99b16f6
Merge branch 'master' into reporting/register-routes-synchro
tsullivan Jun 12, 2020
ed011c0
fix tests
tsullivan Jun 12, 2020
1136503
register route handler context provider
tsullivan Jun 12, 2020
7d75238
Add function level comments in core methods
tsullivan Jun 12, 2020
30d12fe
fix tests
tsullivan Jun 12, 2020
3142b18
revert editor help
tsullivan Jun 12, 2020
a8ff18c
route context is the ReportingStart contract
tsullivan Jun 12, 2020
1e078fc
Fix reporting job route tests
Jun 15, 2020
a7bae68
Fix generation tests
Jun 15, 2020
130bc7b
Merge pull request #8 from joelgriffith/reporting/register-routes-syn…
tsullivan Jun 15, 2020
6e8d535
Merge branch 'master' into reporting/register-routes-synchro
elasticmachine Jun 15, 2020
7d604bc
Merge branch 'master' into reporting/register-routes-synchro
tsullivan Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix generation tests
Joel Griffith committed Jun 15, 2020
commit a7bae6880ddfc320f221afbce69903e06aab7e3f
4 changes: 3 additions & 1 deletion x-pack/plugins/reporting/server/routes/generation.test.ts
View file
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ import { of } from 'rxjs';
type setupServerReturn = UnwrapPromise<ReturnType<typeof setupServer>>;

describe('POST /api/reporting/generate', () => {
const reportingSymbol = Symbol('reporting');
let server: setupServerReturn['server'];
let httpSetup: setupServerReturn['httpSetup'];
let exportTypesRegistry: ExportTypesRegistry;
@@ -47,7 +48,8 @@ describe('POST /api/reporting/generate', () => {
} as unknown) as jest.Mocked<LevelLogger>;

beforeEach(async () => {
({ server, httpSetup } = await setupServer());
({ server, httpSetup } = await setupServer(reportingSymbol));
httpSetup.registerRouteHandlerContext(reportingSymbol, 'reporting', () => ({}));
const mockDeps = ({
elasticsearch: {
legacy: {