Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connectors] A11y refocus manage button #212157

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

meghanmurphy1
Copy link
Contributor

@meghanmurphy1 meghanmurphy1 commented Feb 21, 2025

Summary

As part of Accessibility requirements, a user thats using only the keyboard should be able to know which element they are on at the moment after closing windows. As part of that the 'Ingest Pipelines' page, the 'Manage' button now refocuses once the 'Delete Custom Pipeline' popup is closed. See screenshots below

Closes #196650

Screenshot 2025-02-21 at 3 20 47 PM Screenshot 2025-02-21 at 3 19 53 PM Screenshot 2025-02-21 at 3 20 05 PM Screenshot 2025-02-21 at 3 20 16 PM

Notice that the 'Manage' button is refocused

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@meghanmurphy1 meghanmurphy1 self-assigned this Feb 21, 2025
@meghanmurphy1 meghanmurphy1 added backport:version Backport to applied version labels v9.0.0 labels Feb 21, 2025
@meghanmurphy1 meghanmurphy1 marked this pull request as ready for review February 21, 2025 20:44
@meghanmurphy1 meghanmurphy1 requested a review from a team as a code owner February 21, 2025 20:44
@meghanmurphy1 meghanmurphy1 added the release_note:skip Skip the PR/issue when compiling release notes label Feb 21, 2025
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the issue shouldn't we also focus on an element when we complete the delete action?

Expected Result

Focus should be on Manage button.
After pressing Enter on Delete pipeline, it would be better to have focus on the first element on the page (for this page probably Pipelines tab would be better).


const onCloseHandler = () => {
closeDeleteModal();
setTimeout(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to use the setTimeout here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I've read, the action closeDeleteModal re-renders and without the setTimeout the refocus will fail since the DOM hadn't updated yet.

@meghanmurphy1
Copy link
Contributor Author

Looking at the issue shouldn't we also focus on an element when we complete the delete action?

Expected Result
Focus should be on Manage button.
After pressing Enter on Delete pipeline, it would be better to have focus on the first element on the page (for this page probably Pipelines tab would be better).

Ahhh yes must have missed this. I think I can just add another button refrence for the Pipelines Tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search:Indices:Pipelines page] Manage button missing focus after closing or cancelling the dialog
3 participants