Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] [Security Solution] - Feat Add Severity and risk_score to the Siem migrations (#211202) #212119

Open
wants to merge 1 commit into
base: 9.0
Choose a base branch
from

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

…m migrations (elastic#211202)

## Summary

Handles below Features:
- elastic/security-team#11837

This PR adds `risk_score` and `severity` based on below 3 rules
- `Rule Severity` should be mapped to Splunk's `alert.severity`.
- `Rule Severity` values should be mapped as mentioned in below section
Mapping Elastic Security Rule's Severity with Splunk's Severity

>
> |Splunk's Severity| Elastic Rule Severity |
> |---|---|
> |1- Info|Low|
> |2-Low|Low|
> |3-Medium|Medium|
> |4-High|High|
> |5-Critical|Critical|

- Elastic Security Rule's `Risk Score` derived from the `Severity` of
the Rulet based on below mapping(
[Source](https://www.elastic.co/guide/en/security/current/rules-ui-create.html#rule-ui-basic-params)
)

![Image](https://github.com/user-attachments/assets/d88acd1f-9b73-467f-bf16-0dbecadec465)

## Desk Testing

[splunk_rules_test_severity.json](https://github.com/user-attachments/files/18825855/splunk_rules_test_severity.json)

1. Use the above attached test file which has the `alert.severity`
exported from Splunk.
2. Check the Severity of the translated rule should match the mapping
given above. Expect results like below :

<img width="1474" alt="Screenshot 2025-02-17 at 14 19 23"
src="https://github.com/user-attachments/assets/a8459c71-3208-480e-8049-05293a0a3d2a"
/>

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 74ef9fc)
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 21, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / AddObservable opens the modal when clicked
  • [job] [logs] Detection Engine - Security Solution Cypress Tests #1 / Rule actions during detection rule creation Forwards the correct rule type id to the Cases system action Forwards the correct rule type id to the Cases system action

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.8MB 8.8MB -21.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 85.6KB 85.7KB +89.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 577 579 +2

Total ESLint disabled count

id before after diff
securitySolution 660 662 +2

History

cc @logeekal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants