Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [dashboard] remove legacy section from 'Add panel' flyout (#208116) #209016

Merged
merged 4 commits into from
Jan 31, 2025
Merged

[8.x] [dashboard] remove legacy section from 'Add panel' flyout (#208116) #209016

merged 4 commits into from
Jan 31, 2025

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 30, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nreese
[dashboard] remove legacy section from 'Add panel' flyout (elastic#20…
aa69495 
…8116)

Users should use Lens to visualize data. Users should not use TSVB or
aggregation based panels. To this end, "easy button" UIs, such as
dashboard's "Add panel" flyout, should guide users to lens and not guide
them to legacy applications.

This PR removes `legacy` section from dashboard "Add panel" flyout.
Users can still add legacy panels to dashboards via "visualize"
application. The path is more steps, but this is as intended. Using old
stuff should be painful and require extra work as a caret to move users
to new stuff.

<img width="500" alt="Screenshot 2025-01-23 at 1 08 41 PM"
src="https://github.com/user-attachments/assets/e142cba9-a880-4ad6-a3f8-a981a03daaec"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 7587681)

# Conflicts:
#	test/functional/apps/dashboard/group1/create_and_add_embeddables.ts
@nreese nreese requested a review from kibanamachine as a code owner January 30, 2025 19:34
@nreese nreese enabled auto-merge (squash) January 30, 2025 19:34
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jan 30, 2025
@nreese nreese mentioned this pull request Jan 30, 2025
Merged
@nreese nreese merged commit 0603a87 into elastic:8.x Jan 31, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualizations 484 483 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 145 141 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 596.6KB 596.5KB -76.0B
visualizations 353.2KB 351.6KB -1.6KB
total -1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 22.5KB 22.3KB -194.0B
infra 55.9KB 55.9KB -1.0B
visualizations 38.8KB 38.5KB -316.0B
total -511.0B
Unknown metric groups

API count

id before after diff
embeddable 172 168 -4

async chunk count

id before after diff
visualizations 20 19 -1

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport Feature:Embedding Embedding content via iFrame
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @Heenawter @kibanamachine