Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ColorMapping] Allow storing raw values in color assignments #207957

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[ColorMapping] Allow storing raw values in color assignments #207957

wants to merge 13 commits into from
+1,525 −686

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Jan 23, 2025 •
edited
Loading

Summary

Refactors color mapping logic to store raw values in save objects.

Main changes:

  • Instead assignments having a single rule with many values, we now have assignments with multiple rules of varying types with a single value.
  • As per the previous change, there is no more explicit auto rule, this is now implicit when there are no rules in the assignment.
  • Raw values can now be raw and in cases such as RangeKeys and MultiValueKeys can be instance values. This is not ok for storing in redux nor the SO so be have added a serialize methods to facilitate this value storage. Code changes attempt to identify which value is used based on variable/param names and type aliases as both are unknown.
  • For values that are non-string or non-number types, we no longer allow creating custom matching options.
  • Values are now correctly formatted.
  • More to be added....

Closes #193080
Fixes #187519

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

  • Migration from previous stored types.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 23, 2025 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 23, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@nickofthyme
Merge branch 'main' into fix-color-range-mappings
9ab8476
@nickofthyme
Merge branch 'main' into fix-color-range-mappings
b1d6ebe
@nickofthyme
fix: rangeKey value logic, add tests
ad19861
@nickofthyme
fix: issue with legacy palette categories
5328669 
- use stringified categories for legacy palettes
- pass formatter to all color mapping usages
- cleanup new color mapping toggle logic
- only compute categories when color mapping is enabled
@nickofthyme
fix: issue serializing null and undefined
b7d5aa9
@nickofthyme
fix: sparse transpose datatable color mapping. applies changes from e…
c4e463c 
…lastic#208623

- only handle untransposed data to collate categories
- use untransposed data in lens datatable renderer
- updates usages of getColorCategories
@nickofthyme
fix transpose data undefined issue
84e577d
@nickofthyme
fix: improve select matching
a0fed2e 
- match with or without formatting
- match rule should only match full values
@nickofthyme
add help dot warn message for toggle button
6c7a123
@nickofthyme
fix(xy): color assignment on complex split accessors
9a0ef30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nickofthyme @elasticmachine @kibanamachine