Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Add logging messages to simplify CPU profiling #207885

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Jan 22, 2025

Summary

Resolves #206052.

@dokmic dokmic added Feature:Console Dev Tools Console Feature Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.18.0 labels Jan 22, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #59 / console app console autocomplete feature should provide basic auto-complete functionality
  • [job] [logs] Jest Tests #21 / useGetActionLicense unhappy path

Metrics [docs]

✅ unchanged

@dokmic dokmic added the backport:version Backport to applied version labels label Jan 23, 2025
@dokmic dokmic requested a review from a team January 24, 2025 09:41
Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dokmic dokmic force-pushed the feature/cpu-profiler-logging branch from 89e4222 to ace2bf7 Compare January 27, 2025 16:41
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@dokmic dokmic merged commit 5310034 into elastic:main Jan 27, 2025
8 checks passed
@dokmic dokmic deleted the feature/cpu-profiler-logging branch January 27, 2025 20:30
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12997755335

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 27, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 27, 2025
…208445)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[CLI] Add logging messages to simplify CPU profiling
(#207885)](#207885)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Michael
Dokolin","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-27T20:30:22Z","message":"[CLI]
Add logging messages to simplify CPU profiling (#207885)\n\nResolves
#206052.","sha":"5310034af2efedaec94cbf82c2c254a6c74a330f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0"],"title":"[CLI]
Add logging messages to simplify CPU
profiling","number":207885,"url":"https://github.com/elastic/kibana/pull/207885","mergeCommit":{"message":"[CLI]
Add logging messages to simplify CPU profiling (#207885)\n\nResolves
#206052.","sha":"5310034af2efedaec94cbf82c2c254a6c74a330f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207885","number":207885,"mergeCommit":{"message":"[CLI]
Add logging messages to simplify CPU profiling (#207885)\n\nResolves
#206052.","sha":"5310034af2efedaec94cbf82c2c254a6c74a330f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Michael Dokolin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more logging to CPU profiling instrumentation and test on ECE
4 participants