Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet][Integrations] Add callout to Microsoft Defender integrations showing support for bi-directional response actions #207861

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fleet][Integrations] Add callout to Microsoft Defender integrations showing support for bi-directional response actions #207861

wants to merge 2 commits into from
+116 −77

Conversation

paul-tavares
Copy link
Contributor

Summary

  • Add dismissible callout indicating support for bi-directional response actions to the following integration: Overview page:
    • Microsoft Defender for Endpoint
    • Microsoft M365 Defender
image



image

Checklist

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 labels Jan 22, 2025
@paul-tavares paul-tavares self-assigned this Jan 22, 2025
@paul-tavares paul-tavares marked this pull request as ready for review January 22, 2025 15:32
@paul-tavares paul-tavares requested a review from a team as a code owner January 22, 2025 15:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@paul-tavares paul-tavares requested review from a team, tomsonpl and gergoabraham and removed request for a team January 22, 2025 15:32
paul-tavares
paul-tavares commented Jan 22, 2025
View reviewed changes
...red/fleet/public/applications/integrations/sections/epm/screens/detail/overview/overview.tsx
</>
)}

<BidirectionalIntegrationsBanner integrationPackageName={packageInfo.name} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored the component and moved all business logic to it so it can scale better as we add support for more integrations and to help manage it in a single place

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 22, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 🚀

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #103 / serverless search UI Serverless Playground Overview has embedded console
  • [job] [logs] Jest Tests #21 / useGetCaseUserActionsStats shows a toast error when the API returns an error

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB -81.0B

cc @paul-tavares

gergoabraham
gergoabraham approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and works great! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gergoabraham gergoabraham gergoabraham approved these changes

@nchaulet nchaulet nchaulet approved these changes

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl was automatically assigned from elastic/security-defend-workflows

Assignees

@paul-tavares paul-tavares

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paul-tavares @elasticmachine @nchaulet @gergoabraham