[Fleet] Remove deprecated ML job property from test fixtures #207857
Merged
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
approved these changes
Jan 22, 2025
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
cc @kpollich |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 22, 2025
…#207857) ## Summary Replace `estimated_heap_memory_usage_bytes` property with `expected model_size_bytes` per deprecation warning. I unzipped the fixture archives, replaced the property, and rezipped them. ## To test Add the following to your `serverArgs` block in `x-pack/test/fleet_api_integration/config.base.ts` ``` { name: 'elasticsearch.debug', level: 'debug', appenders: ['default'], }, ``` Run the EPM FTR tests e.g. ``` FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:server --config x-pack/test/fleet_api_integration/config.epm.ts # in another terminal session FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/test/fleet_api_integration/config.epm.ts --grep "Assets tagging" ``` Check that the deprecation notice does not appear in the `elasticsearch.debug` logs in your console ``` x-pack/test/fleet_api_integration/apis/epm/bulk_get_assets.ts: Deprecated field estimated_heap_memory_usage_bytes used, expected model_size_bytes instead ``` (cherry picked from commit 4073aff)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 22, 2025
…207857) (#207886) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Remove deprecated ML job property from test fixtures (#207857)](#207857) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-22T17:03:55Z","message":"[Fleet] Remove deprecated ML job property from test fixtures (#207857)\n\n## Summary\r\n\r\nReplace `estimated_heap_memory_usage_bytes` property with `expected\r\nmodel_size_bytes` per deprecation warning. I unzipped the fixture\r\narchives, replaced the property, and rezipped them.\r\n\r\n## To test\r\n\r\nAdd the following to your `serverArgs` block in\r\n`x-pack/test/fleet_api_integration/config.base.ts`\r\n\r\n```\r\n{\r\n name: 'elasticsearch.debug',\r\n level: 'debug',\r\n appenders: ['default'],\r\n},\r\n```\r\n\r\nRun the EPM FTR tests e.g. \r\n\r\n```\r\nFLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:server --config x-pack/test/fleet_api_integration/config.epm.ts \r\n\r\n# in another terminal session\r\nFLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/test/fleet_api_integration/config.epm.ts --grep \"Assets tagging\"\r\n```\r\n\r\nCheck that the deprecation notice does not appear in the\r\n`elasticsearch.debug` logs in your console\r\n\r\n```\r\nx-pack/test/fleet_api_integration/apis/epm/bulk_get_assets.ts: Deprecated field estimated_heap_memory_usage_bytes used, expected model_size_bytes instead\r\n```","sha":"4073aff617e1fa2fa09f9414df0e398d47159b41","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] Remove deprecated ML job property from test fixtures","number":207857,"url":"https://github.com/elastic/kibana/pull/207857","mergeCommit":{"message":"[Fleet] Remove deprecated ML job property from test fixtures (#207857)\n\n## Summary\r\n\r\nReplace `estimated_heap_memory_usage_bytes` property with `expected\r\nmodel_size_bytes` per deprecation warning. I unzipped the fixture\r\narchives, replaced the property, and rezipped them.\r\n\r\n## To test\r\n\r\nAdd the following to your `serverArgs` block in\r\n`x-pack/test/fleet_api_integration/config.base.ts`\r\n\r\n```\r\n{\r\n name: 'elasticsearch.debug',\r\n level: 'debug',\r\n appenders: ['default'],\r\n},\r\n```\r\n\r\nRun the EPM FTR tests e.g. \r\n\r\n```\r\nFLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:server --config x-pack/test/fleet_api_integration/config.epm.ts \r\n\r\n# in another terminal session\r\nFLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/test/fleet_api_integration/config.epm.ts --grep \"Assets tagging\"\r\n```\r\n\r\nCheck that the deprecation notice does not appear in the\r\n`elasticsearch.debug` logs in your console\r\n\r\n```\r\nx-pack/test/fleet_api_integration/apis/epm/bulk_get_assets.ts: Deprecated field estimated_heap_memory_usage_bytes used, expected model_size_bytes instead\r\n```","sha":"4073aff617e1fa2fa09f9414df0e398d47159b41"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207857","number":207857,"mergeCommit":{"message":"[Fleet] Remove deprecated ML job property from test fixtures (#207857)\n\n## Summary\r\n\r\nReplace `estimated_heap_memory_usage_bytes` property with `expected\r\nmodel_size_bytes` per deprecation warning. I unzipped the fixture\r\narchives, replaced the property, and rezipped them.\r\n\r\n## To test\r\n\r\nAdd the following to your `serverArgs` block in\r\n`x-pack/test/fleet_api_integration/config.base.ts`\r\n\r\n```\r\n{\r\n name: 'elasticsearch.debug',\r\n level: 'debug',\r\n appenders: ['default'],\r\n},\r\n```\r\n\r\nRun the EPM FTR tests e.g. \r\n\r\n```\r\nFLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:server --config x-pack/test/fleet_api_integration/config.epm.ts \r\n\r\n# in another terminal session\r\nFLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/test/fleet_api_integration/config.epm.ts --grep \"Assets tagging\"\r\n```\r\n\r\nCheck that the deprecation notice does not appear in the\r\n`elasticsearch.debug` logs in your console\r\n\r\n```\r\nx-pack/test/fleet_api_integration/apis/epm/bulk_get_assets.ts: Deprecated field estimated_heap_memory_usage_bytes used, expected model_size_bytes instead\r\n```","sha":"4073aff617e1fa2fa09f9414df0e398d47159b41"}}]}] BACKPORT--> Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
estimated_heap_memory_usage_bytesproperty withexpected model_size_bytesper deprecation warning. I unzipped the fixture archives, replaced the property, and rezipped them.To test
Add the following to your
serverArgsblock inx-pack/test/fleet_api_integration/config.base.tsRun the EPM FTR tests e.g.
Check that the deprecation notice does not appear in the
elasticsearch.debuglogs in your console