Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix incorrect default value for History Window Size #207827

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Security Solution] Fix incorrect default value for History Window Size #207827

wants to merge 1 commit into from
+6 −6

Conversation

nikitaindik
Copy link
Contributor

@nikitaindik nikitaindik commented Jan 22, 2025 •
edited
Loading

Resolves: #207348

Summary

This PR resolves a bug in the editable History Window Size component, which incorrectly displays "0 seconds" as the default value instead of "7 days". The issue was caused by passing an array of units (['m', 'h', 'd']) using an incorrect prop name.

Work started on: 22-Jan-2025

@nikitaindik nikitaindik added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Rule Creation Security Solution Detection Rule Creation workflow Feature:Rule Edit Security Solution Detection Rule Editing workflow backport:version Backport to applied version labels v8.18.0 labels Jan 22, 2025
@nikitaindik nikitaindik self-assigned this Jan 22, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 22, 2025 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@nikitaindik nikitaindik mentioned this pull request Jan 22, 2025
Open
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #19 / RegisteredAttachmentsPropertyActions renders the correct number of actions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.3MB 21.3MB -4.0B

cc @nikitaindik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikitaindik nikitaindik

Labels
backport:version Backport to applied version labels Feature:Rule Creation Security Solution Detection Rule Creation workflow Feature:Rule Edit Security Solution Detection Rule Editing workflow release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
2 participants
@nikitaindik @elasticmachine