[Onboarding] Additional auto-detect flow telemetry #207726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykolaharmash
added
release_note:skip
mykolaharmash
force-pushed
the
improve-auto-detect-telemetry
branch
5 times, most recently
from
6be0e21 to
8023da9
Compare
mykolaharmash
commented
Jan 22, 2025
| @@ -53,10 +52,6 @@ export function ObservabilityOnboardingAppRoot({ | |||
| context, | |||
| }; | |||
|
|
|||
| core.analytics.reportEvent(OBSERVABILITY_ONBOARDING_TELEMETRY_EVENT.eventType, { | |||
| uses_legacy_onboarding_page: false, | |||
| }); | |||
There was a problem hiding this comment.
Deleting this one as legacy onboarding page is not a thing anymore. Also deleted uses_legacy_onboarding_page property from the even schema.
mykolaharmash
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
flash1293
reviewed
Jan 24, 2025
There was a problem hiding this comment.
I tested this for the full flow and it seems to work fine for the happy path (except for the "initialized" message, see below).
However it logs
auto_detect.sh: line 16: update_step_progress: command not found
And when provoking a failure e.g. in the os/arch check, it just raises the same error again.
I got it to work by moving the update_step_progress definition further up, but then it fails with another error because the error message contains doublequotes which mess up the JSON of the payload.
So I think we need to do two things:
- Make sure the update_progress function is defined early enough
- Make sure the JSON payload is constructed correctly even for the error case (no doublequotes)
mykolaharmash
force-pushed
the
improve-auto-detect-telemetry
branch
2 times, most recently
from
3b27e41 to
b560550
Compare
|
Thank you @flash1293! The |
escape quotes in the message
mykolaharmash
force-pushed
the
improve-auto-detect-telemetry
branch
from
b560550 to
902446b
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
flash1293
approved these changes
Jan 27, 2025
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Seems like it was still the previous commit, it says line 16 but there is no function call on that line anymore |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mykolaharmash
added a commit
to mykolaharmash/kibana
that referenced
this pull request
Jan 28, 2025
Closes elastic/observability-dev#4236 🔒 This change: * Moves flow progress update telemetry events to the backend (this will prevent situations when multiple progress updates happened in a short time interval, but frontend could only see the latest update because it checks for progress once in a few seconds which might not be enough in some situations) * Leaves the data_ingested final event on the FE because it's not explicitly triggered on the BE * Deletes a separate event type for auto detect flow in favor of the generic even used by other flows * Adds progress updates to the auto-detect script when when it's being run on unsupported OS or lsof binary is not present * Adds logging of the OS and architecture used by the host Events coming from your local Kibana can viewed on the [🔒 Staging Telemetry cluster](https://telemetry-v2-staging.elastic.dev). Though keep in mind, there is a ~1 hour delay for events indexing 😔 Example event:  (cherry picked from commit ef96cd5) # Conflicts: # x-pack/solutions/observability/plugins/observability_onboarding/public/application/quickstart_flows/custom_logs/install_elastic_agent.tsx
mykolaharmash
added a commit
that referenced
this pull request
Jan 28, 2025
…208489) # Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding] Additional auto-detect flow telemetry (#207726)](#207726) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-27T16:19:01Z","message":"[Onboarding] Additional auto-detect flow telemetry (#207726)\n\nCloses elastic/observability-dev#4236 🔒\r\n\r\nThis change:\r\n* Moves flow progress update telemetry events to the backend (this will\r\nprevent situations when multiple progress updates happened in a short\r\ntime interval, but frontend could only see the latest update because it\r\nchecks for progress once in a few seconds which might not be enough in\r\nsome situations)\r\n* Leaves the data_ingested final event on the FE because it's not\r\nexplicitly triggered on the BE\r\n* Deletes a separate event type for auto detect flow in favor of the\r\ngeneric even used by other flows\r\n* Adds progress updates to the auto-detect script when when it's being\r\nrun on unsupported OS or lsof binary is not present\r\n* Adds logging of the OS and architecture used by the host\r\n\r\nEvents coming from your local Kibana can viewed on the [🔒 Staging\r\nTelemetry cluster](https://telemetry-v2-staging.elastic.dev). Though\r\nkeep in mind, there is a ~1 hour delay for events indexing 😔\r\n\r\nExample event:\r\n","sha":"ef96cd5d0b9cba3f03a00ff8b6e1e93840119570","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"[Onboarding] Additional auto-detect flow telemetry","number":207726,"url":"https://github.com/elastic/kibana/pull/207726","mergeCommit":{"message":"[Onboarding] Additional auto-detect flow telemetry (#207726)\n\nCloses elastic/observability-dev#4236 🔒\r\n\r\nThis change:\r\n* Moves flow progress update telemetry events to the backend (this will\r\nprevent situations when multiple progress updates happened in a short\r\ntime interval, but frontend could only see the latest update because it\r\nchecks for progress once in a few seconds which might not be enough in\r\nsome situations)\r\n* Leaves the data_ingested final event on the FE because it's not\r\nexplicitly triggered on the BE\r\n* Deletes a separate event type for auto detect flow in favor of the\r\ngeneric even used by other flows\r\n* Adds progress updates to the auto-detect script when when it's being\r\nrun on unsupported OS or lsof binary is not present\r\n* Adds logging of the OS and architecture used by the host\r\n\r\nEvents coming from your local Kibana can viewed on the [🔒 Staging\r\nTelemetry cluster](https://telemetry-v2-staging.elastic.dev). Though\r\nkeep in mind, there is a ~1 hour delay for events indexing 😔\r\n\r\nExample event:\r\n","sha":"ef96cd5d0b9cba3f03a00ff8b6e1e93840119570"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207726","number":207726,"mergeCommit":{"message":"[Onboarding] Additional auto-detect flow telemetry (#207726)\n\nCloses elastic/observability-dev#4236 🔒\r\n\r\nThis change:\r\n* Moves flow progress update telemetry events to the backend (this will\r\nprevent situations when multiple progress updates happened in a short\r\ntime interval, but frontend could only see the latest update because it\r\nchecks for progress once in a few seconds which might not be enough in\r\nsome situations)\r\n* Leaves the data_ingested final event on the FE because it's not\r\nexplicitly triggered on the BE\r\n* Deletes a separate event type for auto detect flow in favor of the\r\ngeneric even used by other flows\r\n* Adds progress updates to the auto-detect script when when it's being\r\nrun on unsupported OS or lsof binary is not present\r\n* Adds logging of the OS and architecture used by the host\r\n\r\nEvents coming from your local Kibana can viewed on the [🔒 Staging\r\nTelemetry cluster](https://telemetry-v2-staging.elastic.dev). Though\r\nkeep in mind, there is a ~1 hour delay for events indexing 😔\r\n\r\nExample event:\r\n","sha":"ef96cd5d0b9cba3f03a00ff8b6e1e93840119570"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/observability-dev/issues/4236 🔒
This change:
Events coming from your local Kibana can viewed on the 🔒 Staging Telemetry cluster. Though keep in mind, there is a ~1 hour delay for events indexing 😔
Example event:
