Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test and remove skip MKI tag #207574

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix test and remove skip MKI tag #207574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/create_slo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { cleanup, generate } from '@kbn/data-forge';
import expect from '@kbn/expect';
import { RoleCredentials } from '@kbn/ftr-common-functional-services';
import { getSLOSummaryTransformId, getSLOTransformId } from '@kbn/slo-plugin/common/constants';
import { UserProfile } from '@kbn/test/src/auth/types';
import { DeploymentAgnosticFtrProviderContext } from '../../../ftr_provider_context';
import { DEFAULT_SLO } from './fixtures/slo';
import { DATA_FORGE_CONFIG } from './helpers/dataforge';
Expand All @@ -27,12 +28,14 @@ export default function ({ getService }: DeploymentAgnosticFtrProviderContext) {

let adminRoleAuthc: RoleCredentials;
let transformHelper: TransformHelper;
let userData: UserProfile;

describe('Create SLOs', function () {
// see details: https://github.com/elastic/kibana/issues/207354
this.tags(['failsOnMKI']);
before(async () => {
adminRoleAuthc = await samlAuth.createM2mApiKeyWithRoleScope('admin');
userData = await samlAuth.getUserData('admin');
transformHelper = createTransformHelper(getService);

await generate({ client: esClient, config: DATA_FORGE_CONFIG, logger });
Expand Down Expand Up @@ -64,9 +67,9 @@ export default function ({ getService }: DeploymentAgnosticFtrProviderContext) {
expect(definitions.results[0]).eql({
budgetingMethod: 'occurrences',
updatedAt: definitions.results[0].updatedAt,
updatedBy: 'elastic_admin',
updatedBy: userData.username,
createdAt: definitions.results[0].createdAt,
createdBy: 'elastic_admin',
createdBy: userData.username,
description: 'Fixture for api integration tests',
enabled: true,
groupBy: 'tags',
Expand Down
Loading