-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Do not reassign actions space #207381
[Fleet] Do not reassign actions space #207381
Conversation
I think this is reasonable. "Pending" actions won't come along since they were initially created in the previous space. Maybe we can document this so it's clear? |
Sure I will add this to space awareness doc request |
…chaulet/kibana into feature-change-space-policy-action-fix
Pinging @elastic/fleet (Team:Fleet) |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @nchaulet |
@elasticmachine merge upstream |
Starting backport for target branches: 8.x |
(cherry picked from commit 24bab86)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Do not reassign actions space (#207381)](#207381) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-22T13:24:20Z","message":"[Fleet] Do not reassign actions space (#207381)","sha":"24bab86aefcab7dcc0e83543d547031a8557023d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] Do not reassign actions space","number":207381,"url":"https://github.com/elastic/kibana/pull/207381","mergeCommit":{"message":"[Fleet] Do not reassign actions space (#207381)","sha":"24bab86aefcab7dcc0e83543d547031a8557023d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207381","number":207381,"mergeCommit":{"message":"[Fleet] Do not reassign actions space (#207381)","sha":"24bab86aefcab7dcc0e83543d547031a8557023d"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Summary
Resolve elastic/elastic-agent#6454
Reassign action spaces was causing issues as it triggered Fleet server to re-distribute the actions to agents (and causing issues due to that).
That PR fix it by not updating previous action space, this cause previous agent activity to not be available in a newly assigned space after a space change, (it seems an acceptable trade-off to me, @nimarezainia @kpollich wdyt?)
Tests