Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Do not reassign actions space #207381

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jan 21, 2025

Summary

Resolve elastic/elastic-agent#6454

Reassign action spaces was causing issues as it triggered Fleet server to re-distribute the actions to agents (and causing issues due to that).
That PR fix it by not updating previous action space, this cause previous agent activity to not be available in a newly assigned space after a space change, (it seems an acceptable trade-off to me, @nimarezainia @kpollich wdyt?)

Tests

  • Updated existing tests

@nchaulet nchaulet self-assigned this Jan 21, 2025
@nchaulet nchaulet added Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 21, 2025
@kpollich
Copy link
Member

I think this is reasonable. "Pending" actions won't come along since they were initially created in the previous space. Maybe we can document this so it's clear?

@nchaulet
Copy link
Member Author

I think this is reasonable. "Pending" actions won't come along since they were initially created in the previous space. Maybe we can document this so it's clear?

Sure I will add this to space awareness doc request

@nchaulet nchaulet marked this pull request as ready for review January 21, 2025 16:08
@nchaulet nchaulet requested a review from a team as a code owner January 21, 2025 16:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Jan 21, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 21, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / DeleteAttachmentConfirmationModal calls onConfirm
  • [job] [logs] Jest Tests #4 / HoverableAvatar renders the tooltip when hovering

Metrics [docs]

✅ unchanged

History

cc @nchaulet

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet merged commit 24bab86 into elastic:main Jan 22, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12909193246

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 22, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 22, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Do not reassign actions space
(#207381)](#207381)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-22T13:24:20Z","message":"[Fleet]
Do not reassign actions space
(#207381)","sha":"24bab86aefcab7dcc0e83543d547031a8557023d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet]
Do not reassign actions
space","number":207381,"url":"https://github.com/elastic/kibana/pull/207381","mergeCommit":{"message":"[Fleet]
Do not reassign actions space
(#207381)","sha":"24bab86aefcab7dcc0e83543d547031a8557023d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207381","number":207381,"mergeCommit":{"message":"[Fleet]
Do not reassign actions space
(#207381)","sha":"24bab86aefcab7dcc0e83543d547031a8557023d"}}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent remains stuck in Outdated policy state for over 10 minutes on updating spaces used by the policy.
5 participants