Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning callout when deleting managed assets #207329

Merged
merged 21 commits into from
Jan 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0e701ac
Create package for warning about deleting managed assets
sabarasaba Jan 21, 2025
83abdb7
Implement delete assets warning callout
sabarasaba Jan 21, 2025
d1aeece
Implement for index templates too
sabarasaba Jan 21, 2025
bc80a9c
Fix linter issues
sabarasaba Jan 21, 2025
ed76761
commit with @elastic email
sabarasaba Jan 21, 2025
a08d467
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Jan 21, 2025
ef3de02
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine Jan 21, 2025
833df70
Add functional tests
sabarasaba Jan 21, 2025
70cf792
Ignore doc page
sabarasaba Jan 21, 2025
c7bc35f
Refactor duped name
sabarasaba Jan 21, 2025
5ed0763
Update src/platform/packages/shared/kbn-management/delete_managed_ass…
sabarasaba Jan 21, 2025
263384f
Update src/platform/packages/shared/kbn-management/delete_managed_ass…
sabarasaba Jan 21, 2025
070c4bd
Update src/platform/packages/shared/kbn-management/delete_managed_ass…
sabarasaba Jan 21, 2025
c199126
Update src/platform/packages/shared/kbn-management/delete_managed_ass…
sabarasaba Jan 21, 2025
2ea886b
Fix tests
sabarasaba Jan 21, 2025
20a3eb5
Should be lowercase
sabarasaba Jan 21, 2025
1e636d2
Merge branch 'main' into delete_managed_assets_callout
elasticmachine Jan 22, 2025
e1959bc
Address copy review
sabarasaba Jan 22, 2025
7b5e01d
Add missing schema param
sabarasaba Jan 27, 2025
524eaa8
Remove unused prop
sabarasaba Jan 27, 2025
dbc949a
Merge branch 'main' into delete_managed_assets_callout
sabarasaba Jan 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address copy review
sabarasaba committed Jan 22, 2025
commit e1959bc0e22487a4274e3336f9deda020fadd90c
Original file line number Diff line number Diff line change
@@ -17,9 +17,9 @@ export default {
};

export const DeleteManagedAssetsCallout = () => {
return <Component assetName="ingest pipeline" />;
return <Component assetName="ingest pipelines" />;
};

export const ErrorDeleteManagedAssetsCallout = () => {
return <Component assetName="ingest pipeline" color="danger" iconType="trash" />;
return <Component assetName="ingest pipelines" color="danger" iconType="trash" />;
};
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ export const DeleteManagedAssetsCallout = ({
<p>
{overrideBody ??
i18n.translate('management.deleteManagedAssetsCallout.body', {
defaultMessage: `Elasticsearch automatically re-creates any missing managed {assetName}. If you delete a managed {assetName}, the deletion appears as successful but the {assetName} is immediately re-created and reappears.`,
defaultMessage: `Elasticsearch automatically re-creates any missing managed {assetName}. If you delete managed {assetName}, the deletion appears as successful, but the {assetName} are immediately re-created and reappear.`,
values: { assetName },
})}
</p>
Original file line number Diff line number Diff line change
@@ -117,7 +117,7 @@ export const TemplateDeleteModal = ({
<>
<DeleteManagedAssetsCallout
assetName={i18n.translate('xpack.idxMgmt.deleteTemplatesModal.assetName', {
defaultMessage: 'Index Template',
defaultMessage: 'index templates',
})}
/>

Original file line number Diff line number Diff line change
@@ -114,7 +114,7 @@ export const PipelineDeleteModal = ({
<>
<DeleteManagedAssetsCallout
assetName={i18n.translate('xpack.ingestPipelines.deleteModal.assetName', {
defaultMessage: 'ingest pipeline',
defaultMessage: 'ingest pipelines',
})}
/>