Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

197621 rename plugin to automatic import #207325

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

haetamoudi
Copy link
Contributor

@haetamoudi haetamoudi commented Jan 21, 2025

Summary

Rename integration-assistant plugin to automatic-import. Github issue

Outdated PR to rename plugin,

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Commands executed

  • node scripts/i18n_check --fix
  • node scripts/lint_ts_projects
  • node scripts/generate codeowners
  • node scripts/build_plugin_list_docs
  • node scripts/build_kibana_platform_plugins.js --update-limits

Testing

  • cypress tests:
    • yarn cypress:run --spec cypress/e2e/privileges_integrations_automatic_import_license.cy.ts ✅
    • yarn cypress:run --spec cypress/e2e/privileges_integrations_automatic_import.cy.ts ✅
    • yarn cypress:run --spec cypress/e2e/integrations_automatic_import.cy.ts
  • manual testing: create and install an integration via the automatic-import plugin ✅
  • unit tests:
    • node scripts/jest -u x-pack/solutions/security/plugins/security_solution_serverless ✅
    • node scripts/jest -u x-pack/platform/plugins/shared/automatic_import ✅

Follow-up

Once the PR is merged, the following dashboards will need to be updated to reflect the Telemetry keys changes:
Looker: https://lookerstudio.google.com/u/0/reporting/5eb00475-46bc-4c57-93da-5b2d00058c8a/page/p_t7j5zagckd?pli=1
Stack Telemetry: https://stack-telemetry.elastic.dev/s/securitysolution/app/dashboards#/view/e7662c09-eedb-49aa-9615-0600fcb[…]60000),time:(from:now-30d%2Fd,to:now))

@haetamoudi haetamoudi self-assigned this Jan 21, 2025
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@haetamoudi
Copy link
Contributor Author

buildkite test this

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 21, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / JsonEditorField calls setValue and xJson on editor change
  • [job] [logs] Jest Tests #6 / RegisteredAttachmentsPropertyActions renders the correct number of actions
  • [job] [logs] Jest Tests #6 / useGetCaseUsers shows a toast error when the api return an error

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
automaticImport - 740 +740

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
automaticImport - 62 +62

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
automaticImport - 1.1MB ⚠️ +1.1MB
fleet 1.7MB 1.7MB -15.0B
securitySolution 21.3MB 21.3MB -50.0B
securitySolutionServerless 141.5KB 141.5KB -26.0B
total ⚠️ +1.1MB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
automaticImport - 4 +4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
automaticImport - 10.1KB +10.1KB
securitySolutionServerless 26.6KB 26.5KB -46.0B
total +10.1KB
Unknown metric groups

API count

id before after diff
automaticImport - 78 +78

async chunk count

id before after diff
automaticImport - 2 +2

ESLint disabled in files

id before after diff
automaticImport - 6 +6

ESLint disabled line counts

id before after diff
automaticImport - 7 +7

miscellaneous assets size

id before after diff
automaticImport - 1.2MB ⚠️ +1.2MB

Total ESLint disabled count

id before after diff
automaticImport - 13 +13

History

cc @haetamoudi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants